jenkins-bot has submitted this change and it was merged. Change subject: Do not use second parameter to jQuery constructor ......................................................................
Do not use second parameter to jQuery constructor It's discouraged by our coding conventions: https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Pitfalls. Change-Id: I78239065e96f30623262b951ab3bb378a1b3ffea --- M lib/resources/jquery.wikibase/snakview/snakview.js 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Thiemo Mättig (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/lib/resources/jquery.wikibase/snakview/snakview.js b/lib/resources/jquery.wikibase/snakview/snakview.js index 862f710..f387a9f 100644 --- a/lib/resources/jquery.wikibase/snakview/snakview.js +++ b/lib/resources/jquery.wikibase/snakview/snakview.js @@ -819,10 +819,9 @@ if( propertyId ) { // property ID selected but apparently no variation available to handle it - this.$snakValue.append( $( '<span/>', { - 'text': mw.msg( 'wikibase-snakview-choosesnaktype' ), - 'class': this.widgetBaseClass + '-unsupportedsnaktype' - } ) ); + $( '<span/>' ).text( mw.msg( 'wikibase-snakview-choosesnaktype' ) ) + .addClass( this.widgetBaseClass + '-unsupportedsnaktype' ) + .appendTo( this.$snakValue ); // NOTE: instead of doing this here and checking everywhere whether this._variation // is set, we could as well use variations for displaying system messages like // this, e.g. having a UnsupportedSnakType variation which is not registered for a -- To view, visit https://gerrit.wikimedia.org/r/165184 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78239065e96f30623262b951ab3bb378a1b3ffea Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Adrian Lang <adrian.l...@wikimedia.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
