Ori.livneh has uploaded a new change for review.
Change subject: (Draft) Fix various problems
......................................................................
(Draft) Fix various problems
- Enumerate globals in .jshintrc and organize configurations.
- Add closure to tests file; use function form of "use strict".
- Quote 'enum' property
- Permit dangling '_' for special case (_db and _id).
- References: module -> QUnit.module, test -> QUnit.test, etc.
- Rename modules/dataModels.js to modules/ext.EventLogging.dataModels.js
- Remove init {} from ext.EventLogging.dataModels.js
- Fix order in $wgResourceModules, ext.EventLogging.js first,
ext.EventLogging.dataModels.js second.
- Replace init {} in ext.EventLogging.js with regular assignment
- Replace call to JSON.stringify with $.toJSON.
- PHP: $wgEventLoggingBaseUri is used but not defined anywhere.
- Use __DIR__
* [jshint] Identifer URI_MAX_BYTES did not pass camelcase-rule.
* [mw:cc] Space after operators (such as 'switch')
* > eventInstance = $.extend( {}, eventInstance ..
Not sure why it clones it, but I'd like a comment explaining why.
And assuming the clone is indeed needed, explain why it doesn't make
a deep clone, or add true as first argument to $.extend().
Change-Id: I810bddad3b8bbabf2daaf1a26444f20a1224775d
---
M .jshintrc
M EventLogging.hooks.php
M EventLogging.php
M modules/dataModels.js
M modules/ext.EventLogging.js
M tests/ext.EventLogging.tests.js
6 files changed, 151 insertions(+), 166 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/31/30131/1
--
To view, visit https://gerrit.wikimedia.org/r/30131
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I810bddad3b8bbabf2daaf1a26444f20a1224775d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
