jenkins-bot has submitted this change and it was merged.
Change subject: Only register and assign "centralnotice-admin" if needed
......................................................................
Only register and assign "centralnotice-admin" if needed
These rights are only needed on wikis that allow editing
CentralNotice related things, so only add them there.
Change-Id: I375270e5b6e688a72ec01ff9e4e018ecaaf94980
---
M CentralNotice.hooks.php
M CentralNotice.php
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jalexander: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php
index ae5843c..db6c2dd 100644
--- a/CentralNotice.hooks.php
+++ b/CentralNotice.hooks.php
@@ -147,6 +147,10 @@
$wgSpecialPages[ 'BannerAllocation' ] =
'SpecialBannerAllocation';
$wgSpecialPages[ 'CentralNoticeLogs' ] =
'SpecialCentralNoticeLogs';
$wgSpecialPages[ 'CentralNoticeBanners'] =
'SpecialCentralNoticeBanners';
+
+ // Register user rights for editing
+ $wgAvailableRights[] = 'centralnotice-admin';
+ $wgGroupPermissions[ 'sysop' ][ 'centralnotice-admin' ] = true;
// Only sysops can make change
}
}
diff --git a/CentralNotice.php b/CentralNotice.php
index 3f420ce..5c65fb8 100644
--- a/CentralNotice.php
+++ b/CentralNotice.php
@@ -235,7 +235,3 @@
$wgMessagesDirs['CentralNotice'] = __DIR__ . '/i18n';
$wgExtensionMessagesFiles['CentralNotice'] = __DIR__ .
"/CentralNotice.i18n.php";
$wgExtensionMessagesFiles[ 'CentralNoticeAliases' ] = $dir .
'/CentralNotice.alias.php';
-
-// Register user rights
-$wgAvailableRights[] = 'centralnotice-admin';
-$wgGroupPermissions[ 'sysop' ][ 'centralnotice-admin' ] = true; // Only sysops
can make change
--
To view, visit https://gerrit.wikimedia.org/r/156077
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I375270e5b6e688a72ec01ff9e4e018ecaaf94980
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jalexander <[email protected]>
Gerrit-Reviewer: Katie Horn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
