Jackmcbarn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/166522
Change subject: Remove negative caching from Revision::getContentInternal
......................................................................
Remove negative caching from Revision::getContentInternal
Negative caching in Revision::getContent can cause race conditions, so
stop doing it.
Bug: 71545
Change-Id: Iac32b2d4f90c4c1ce37820288f757e47b6d895e7
---
M includes/Revision.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/22/166522/1
diff --git a/includes/Revision.php b/includes/Revision.php
index 5b39a41..e81ed75 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -1060,8 +1060,6 @@
$format = $this->getContentFormat();
$this->mContent = $handler->unserializeContent(
$this->mText, $format );
- } else {
- $this->mContent = false; // negative caching!
}
}
--
To view, visit https://gerrit.wikimedia.org/r/166522
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac32b2d4f90c4c1ce37820288f757e47b6d895e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jackmcbarn <jackmcb...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
