Ori.livneh has submitted this change and it was merged.
Change subject: Remove deployment::target
......................................................................
Remove deployment::target
The deployment::target resource has been deprecated in favor of
Trebuchet's custom provider.
Change-Id: I72adfd37d3023173560b16ce71ef8c6a644a6c4b
---
D modules/deployment/manifests/target.pp
1 file changed, 0 insertions(+), 41 deletions(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
Objections:
BryanDavis: There's a problem with this change, please improve
diff --git a/modules/deployment/manifests/target.pp
b/modules/deployment/manifests/target.pp
deleted file mode 100644
index d828e1d..0000000
--- a/modules/deployment/manifests/target.pp
+++ /dev/null
@@ -1,41 +0,0 @@
-define deployment::target($ensure=present) {
- # Need packages before deploy.sync_all
- # is run. (git, git-fat, etc.)
- require deployment::packages
-
- salt::grain { "deployment_target_${name}":
- ensure => $ensure,
- grain => 'deployment_target',
- value => $name,
- notify => [
- Exec['deployment_target_sync_all'],
- Exec['deployment_target_refresh_pillars'],
- Exec['deployment_target_deploy_all'],
- ];
- }
- if ! defined(Exec['deployment_target_sync_all']){
- exec { 'deployment_target_sync_all':
- refreshonly => true,
- path => ['/usr/bin'],
- command => 'salt-call saltutil.sync_all';
- }
- }
- if ! defined(Exec['deployment_target_refresh_pillars']){
- exec { 'deployment_target_refresh_pillars':
- refreshonly => true,
- path => ['/usr/bin'],
- command => 'salt-call saltutil.refresh_pillar';
- }
- }
- if ! defined(Exec['deployment_target_deploy_all']){
- exec { 'deployment_target_deploy_all':
- refreshonly => true,
- path => ['/usr/bin'],
- command => 'salt-call deploy.sync_all',
- require => [
- Exec['deployment_target_sync_all'],
- Exec['deployment_target_refresh_pillars'],
- ];
- }
- }
-}
--
To view, visit https://gerrit.wikimedia.org/r/163376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72adfd37d3023173560b16ce71ef8c6a644a6c4b
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis <[email protected]>
Gerrit-Reviewer: ArielGlenn <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
