jenkins-bot has submitted this change and it was merged.
Change subject: RequestContextTest: Distinguish initial test from restored test
......................................................................
RequestContextTest: Distinguish initial test from restored test
Follows-up f31a046. In failure it's hard to see whether it's the
first or third group of assertions as they were carying the same
name.
Change-Id: I5891754342400155759e797337f8509d4eca39ec
---
M tests/phpunit/includes/RequestContextTest.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/RequestContextTest.php
b/tests/phpunit/includes/RequestContextTest.php
index cae0e52..a9e5be2 100644
--- a/tests/phpunit/includes/RequestContextTest.php
+++ b/tests/phpunit/includes/RequestContextTest.php
@@ -88,9 +88,9 @@
unset( $sc ); // restore previous context
$info = $context->exportSession();
- $this->assertEquals( $oInfo['ip'], $info['ip'], "Correct
initial IP address." );
- $this->assertEquals( $oInfo['headers'], $info['headers'],
"Correct initial headers." );
- $this->assertEquals( $oInfo['sessionId'], $info['sessionId'],
"Correct initial session ID." );
- $this->assertEquals( $oInfo['userId'], $info['userId'],
"Correct initial user ID." );
+ $this->assertEquals( $oInfo['ip'], $info['ip'], "Correct
restored IP address." );
+ $this->assertEquals( $oInfo['headers'], $info['headers'],
"Correct restored headers." );
+ $this->assertEquals( $oInfo['sessionId'], $info['sessionId'],
"Correct restored session ID." );
+ $this->assertEquals( $oInfo['userId'], $info['userId'],
"Correct restored user ID." );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/166712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5891754342400155759e797337f8509d4eca39ec
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
