[MediaWiki-commits] [Gerrit] Fixed some issues in preferences - change (mediawiki...BlueSpiceExtensions)

[Smuggli (Code Review)]

Smuggli has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/166741

Change subject: Fixed some issues in preferences
......................................................................

Fixed some issues in preferences

 * Message was not shown in sort items

Change-Id: I0e51d6c3f87b4f6cd2d570341ddd5eee2bfa0f40
---
M ExtendedSearch/ExtendedSearch.class.php
M Preferences/resources/bluespice.preferences.js
2 files changed, 10 insertions(+), 11 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/41/166741/1

diff --git a/ExtendedSearch/ExtendedSearch.class.php 
b/ExtendedSearch/ExtendedSearch.class.php
index ecf28d0..29c3ce7 100644
--- a/ExtendedSearch/ExtendedSearch.class.php
+++ b/ExtendedSearch/ExtendedSearch.class.php
@@ -206,7 +206,7 @@
         * @return boolean Always true to keep hook running
         */
        public function onBSStateBarAddSortBodyVars( &$aSortBodyVars ) {
-               $aSortBodyVars['statebarbodymorelikethis'] = wfMessage( 
'bs-articleinfo-statebarbodymorelikethis' )->plain();
+               $aSortBodyVars['statebarbodymorelikethis'] = wfMessage( 
'bs-extendedsearch-morelikethis' )->plain();
                return true;
        }
 
diff --git a/Preferences/resources/bluespice.preferences.js 
b/Preferences/resources/bluespice.preferences.js
index fbc3eb1..7746488 100644
--- a/Preferences/resources/bluespice.preferences.js
+++ b/Preferences/resources/bluespice.preferences.js
@@ -1,15 +1,14 @@
-$( document ).ready( function() {
+( function ( mw, bs, $, undefined ) {
        $('.bs-prefs .bs-prefs-head').click( function() {
-               var oPrefsBody = $(this).parent().find('.bs-prefs-body');
-               var sCookieKey  = $(this).parent().attr('id')+'-viewstate';
-               if( oPrefsBody.is(":visible") == true ) {
+               var oPrefsBody = $( this ).parent().find( '.bs-prefs-body' ),
+                       sCookieKey = $( this ).parent().attr( 'id' 
)+'-viewstate';
+               if ( oPrefsBody.is( ":visible" ) == true ) {
                        $(oPrefsBody[0]).slideUp(500);
                        
$(oPrefsBody[0]).parent().addClass('bs-prefs-viewstate-collapsed');
                        $.cookie(sCookieKey, null, {
                                path: '/'
                        });
-               }
-               else {
+               } else {
                        $(oPrefsBody[0]).slideDown(500);
                        
$(oPrefsBody[0]).parent().removeClass('bs-prefs-viewstate-collapsed');
                        $.cookie(sCookieKey, 'opened', {
@@ -18,11 +17,11 @@
                        });
                }
        }).each( function() {
-               var oPrefsBody = $(this).parent().find('.bs-prefs-body');
-               var sCookieKey = $(this).parent().attr('id')+'-viewstate';
-               if( sCookieKey != 'bluespice-viewstate' && ($.cookie( 
sCookieKey ) == null || $.cookie( sCookieKey ) != 'opened')) {
+               var oPrefsBody = $(this).parent().find('.bs-prefs-body'),
+                       sCookieKey = $(this).parent().attr('id')+'-viewstate';
+               if ( sCookieKey != 'bluespice-viewstate' && ($.cookie( 
sCookieKey ) == null || $.cookie( sCookieKey ) != 'opened')) {
                        oPrefsBody.hide();
                        
$(oPrefsBody[0]).parent().addClass('bs-prefs-viewstate-collapsed');
                }
        });
-});
\ No newline at end of file
+}( mediaWiki, blueSpice, jQuery ) );
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/166741
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e51d6c3f87b4f6cd2d570341ddd5eee2bfa0f40
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Smuggli <mug...@hallowelt.biz>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits