jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Correct phpdoc comments
......................................................................
Hygiene: Correct phpdoc comments
Change-Id: Ia2dbce37c97e6a0393fd3f28242b838d7f2e05de
---
M includes/Parsoid/Fixer/BadImageRemover.php
M includes/RevisionActionPermissions.php
M includes/WorkflowLoader.php
3 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Parsoid/Fixer/BadImageRemover.php
b/includes/Parsoid/Fixer/BadImageRemover.php
index 164d04e..2047640 100644
--- a/includes/Parsoid/Fixer/BadImageRemover.php
+++ b/includes/Parsoid/Fixer/BadImageRemover.php
@@ -29,7 +29,7 @@
protected $isFiltered;
/**
- * @var callable $callback (string, Title) returning bool. First
+ * @var callable $isFiltered (string, Title) returning bool. First
* argument is the image name to check. Second argument is the page on
* which the image occurs. Returns true when the image should be
filtered.
*/
diff --git a/includes/RevisionActionPermissions.php
b/includes/RevisionActionPermissions.php
index 599751a..43ee314 100644
--- a/includes/RevisionActionPermissions.php
+++ b/includes/RevisionActionPermissions.php
@@ -180,6 +180,7 @@
*
* @param AbstractRevision|null $revision
* @param string $action
+ * @param string $type
* @return Closure|string
*/
public function getPermission( AbstractRevision $revision = null,
$action, $type = 'permissions' ) {
diff --git a/includes/WorkflowLoader.php b/includes/WorkflowLoader.php
index 9844e00..1dba5c5 100644
--- a/includes/WorkflowLoader.php
+++ b/includes/WorkflowLoader.php
@@ -52,10 +52,10 @@
}
/**
- * @param $action
+ * @param string $action
* @param array $blocks
- * @param $user
- * @param WebRequest $request
+ * @param mixed $user
+ * @param array $params
* @return Block\AbstractBlock[]
*/
public function handleSubmit( $action, array $blocks, $user, array
$params ) {
--
To view, visit https://gerrit.wikimedia.org/r/165876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2dbce37c97e6a0393fd3f28242b838d7f2e05de
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
