Matthias Mullie has submitted this change and it was merged.

Change subject: Bug: Duplicate items on watchlist
......................................................................


Bug: Duplicate items on watchlist

Watchlist was not always being detected correctly, causing beta labs to
not call RecentChangesQuery::isRecordHidden. Patch utilizes the recently
added ChangesList::isWatchlist method to detect when watchlist is being
rendered.

Bug: 71619
Change-Id: I6c7473afdddbcbcf0dd8e5d7949d718e5062661f
---
M Hooks.php
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Matthias Mullie: Verified; Looks good to me, approved



diff --git a/Hooks.php b/Hooks.php
index bc75d68..592539c 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -207,7 +207,10 @@
 
                set_error_handler( new Flow\RecoverableErrorHandler, -1 );
                try {
-                       Container::get( 'query.recentchanges' 
)->loadMetadataBatch( $rows );
+                       Container::get( 'query.recentchanges' 
)->loadMetadataBatch(
+                               $rows,
+                               $changesList->isWatchlist()
+                       );
                } catch ( Exception $e ) {
                        \MWExceptionHandler::logException( $e );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/166916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c7473afdddbcbcf0dd8e5d7949d718e5062661f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to