Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167973
Change subject: GridLayout: Set dimensions.visibility = '' again if we have a
height and a width
......................................................................
GridLayout: Set dimensions.visibility = '' again if we have a height and a width
Ib07797b4 stopped doing this, which caused VE's transclusion dialog to no longer
show the extra options.
Bug: 72278
Change-Id: I99f5ea387bb3153d71c789910f988f3267d92969
---
M src/layouts/GridLayout.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/73/167973/1
diff --git a/src/layouts/GridLayout.js b/src/layouts/GridLayout.js
index dc8a962..cbe92ee 100644
--- a/src/layouts/GridLayout.js
+++ b/src/layouts/GridLayout.js
@@ -128,6 +128,8 @@
// HACK: Work around IE bug by setting visibility:
hidden; if width or height is zero
if ( width === 0 || height === 0 ) {
dimensions.visibility = 'hidden';
+ } else {
+ dimensions.visibility = '';
}
panel.$element.css( dimensions );
i++;
--
To view, visit https://gerrit.wikimedia.org/r/167973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99f5ea387bb3153d71c789910f988f3267d92969
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
