jenkins-bot has submitted this change and it was merged.
Change subject: Adding error handling to askWikidataQuestion for WikiGrok
version A
......................................................................
Adding error handling to askWikidataQuestion for WikiGrok version A
Also removing unnecessary duplicate code.
Change-Id: I629d59b4c270e6e17143af066b990673b19b2b8f
---
M javascripts/modules/wikigrok/WikiGrokDialog.js
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/wikigrok/WikiGrokDialog.js
b/javascripts/modules/wikigrok/WikiGrokDialog.js
index a990856..f2a2e87 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialog.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialog.js
@@ -89,18 +89,21 @@
];
options.noticeMsg = 'All
submissions are <a class="wg-notice-link" href="#/wikigrok/about">released
freely</a>';
self.render( options );
+ } else {
+ self.showError( options, "There
was an error retrieving tag labels." );
}
- options.buttons = [
- { classes: 'yes inline
mw-ui-button mw-ui-progressive', label: 'Yes' },
- { classes: 'not-sure inline
mw-ui-button', label: 'Not Sure' },
- { classes: 'no inline
mw-ui-button mw-ui-progressive', label: 'No' }
- ];
- options.noticeMsg = 'All submissions
are <a class="wg-notice-link" href="#/wikigrok/about">released freely</a>';
- self.render( options );
} );
}
},
+ showError: function( options, errorMsg ) {
+ options.contentMsg = errorMsg;
+ options.buttons = [
+ { classes: 'cancel inline mw-ui-button
mw-ui-progressive', label: 'OK' },
+ ];
+ this.render( options );
+ },
+
// Record answer in temporary database for analysis.
// Eventually answers will be recorded directly to Wikidata.
recordClaim: function( options ) {
--
To view, visit https://gerrit.wikimedia.org/r/167949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I629d59b4c270e6e17143af066b990673b19b2b8f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
