tosfos has uploaded a new change for review.
https://gerrit.wikimedia.org/r/167984
Change subject: Do not show a warning if two categories have the same default
form
......................................................................
Do not show a warning if two categories have the same default form
Change-Id: Ibe9b4323d6fef9f3bbff38c9dc40613743ea3ebd
---
M includes/SF_FormLinker.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms
refs/changes/84/167984/1
diff --git a/includes/SF_FormLinker.php b/includes/SF_FormLinker.php
index 8aa273d..3fc0e6f 100644
--- a/includes/SF_FormLinker.php
+++ b/includes/SF_FormLinker.php
@@ -334,7 +334,9 @@
$default_forms = array_merge( $default_forms,
self::getFormsThatPagePointsTo( $category, NS_CATEGORY, self::DEFAULT_FORM ) );
}
if ( count( $default_forms ) > 0 ) {
- return $default_forms;
+ // It is possible for two categories to have
the same default form, so purge any
+ // duplicates from the array to avoid a "more
than one default form" warning.
+ return array_unique( $default_forms );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/167984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe9b4323d6fef9f3bbff38c9dc40613743ea3ebd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: tosfos <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
