Brion VIBBER has submitted this change and it was merged. Change subject: Transition to AFNetworking from MWNetworkOp. ......................................................................
Transition to AFNetworking from MWNetworkOp. Added cocoapods Podfile and through it, AFNetworking and HPPLE. Note: build script is in place but commented out. Also, auto integration with workspace instead of xcodeproj is still too messy so the build script uses "no-integrate" flag and we manually reference the files we need for now. [I think I cleaned up the project integration mostly, but it still won't auto-update. But it auto-builds now. :D -brion] Fix for auto-login crash after creating an account. Handles ssl fail-over in more central place, not just in article retrieval. Search results ordering updated to reflect recent update to mobile web search. Fix for edit token parameters being deprecated. Scale Wikipedia Zero message bar (at bottom of screen) to scale with other native interface elements on iPads. Cleared out old testing cruft. New testing soon! Fix for search and nearby thumbnail images not loading on iOS 6 and 7. Modified fetchers to properly "sanitize" responses and used "isDict" category method rather than "isSubclassOfClass". Change-Id: I991fac86a8788d3fd25595849b618a3d1ee7e699 --- M Wikipedia.xcodeproj/project.pbxproj D Wikipedia.xcodeproj/xcshareddata/xcschemes/Debug Wikipedia-iOS.xcscheme M Wikipedia.xcodeproj/xcshareddata/xcschemes/Wikipedia-iOS.xcscheme A cocoapods notes.txt A cocoapods/Podfile A cocoapods/Podfile.lock A cocoapods/Pods/AFNetworking/AFNetworking/AFHTTPRequestOperation.h A cocoapods/Pods/AFNetworking/AFNetworking/AFHTTPRequestOperation.m A cocoapods/Pods/AFNetworking/AFNetworking/AFHTTPRequestOperationManager.h A cocoapods/Pods/AFNetworking/AFNetworking/AFHTTPRequestOperationManager.m A cocoapods/Pods/AFNetworking/AFNetworking/AFHTTPSessionManager.h A cocoapods/Pods/AFNetworking/AFNetworking/AFHTTPSessionManager.m A cocoapods/Pods/AFNetworking/AFNetworking/AFNetworkReachabilityManager.h A cocoapods/Pods/AFNetworking/AFNetworking/AFNetworkReachabilityManager.m A cocoapods/Pods/AFNetworking/AFNetworking/AFNetworking.h A cocoapods/Pods/AFNetworking/AFNetworking/AFSecurityPolicy.h A cocoapods/Pods/AFNetworking/AFNetworking/AFSecurityPolicy.m A cocoapods/Pods/AFNetworking/AFNetworking/AFURLConnectionOperation.h A cocoapods/Pods/AFNetworking/AFNetworking/AFURLConnectionOperation.m A cocoapods/Pods/AFNetworking/AFNetworking/AFURLRequestSerialization.h A cocoapods/Pods/AFNetworking/AFNetworking/AFURLRequestSerialization.m A cocoapods/Pods/AFNetworking/AFNetworking/AFURLResponseSerialization.h A cocoapods/Pods/AFNetworking/AFNetworking/AFURLResponseSerialization.m A cocoapods/Pods/AFNetworking/AFNetworking/AFURLSessionManager.h A cocoapods/Pods/AFNetworking/AFNetworking/AFURLSessionManager.m A cocoapods/Pods/AFNetworking/LICENSE A cocoapods/Pods/AFNetworking/README.md A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/AFNetworkActivityIndicatorManager.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/AFNetworkActivityIndicatorManager.m A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIAlertView+AFNetworking.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIAlertView+AFNetworking.m A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIButton+AFNetworking.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIButton+AFNetworking.m A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIImageView+AFNetworking.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIImageView+AFNetworking.m A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIKit+AFNetworking.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIProgressView+AFNetworking.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIProgressView+AFNetworking.m A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIWebView+AFNetworking.h A cocoapods/Pods/AFNetworking/UIKit+AFNetworking/UIWebView+AFNetworking.m A cocoapods/Pods/Headers/Build/AFNetworking/AFHTTPRequestOperation.h A cocoapods/Pods/Headers/Build/AFNetworking/AFHTTPRequestOperationManager.h A cocoapods/Pods/Headers/Build/AFNetworking/AFHTTPSessionManager.h A cocoapods/Pods/Headers/Build/AFNetworking/AFNetworkActivityIndicatorManager.h A cocoapods/Pods/Headers/Build/AFNetworking/AFNetworkReachabilityManager.h A cocoapods/Pods/Headers/Build/AFNetworking/AFNetworking.h A cocoapods/Pods/Headers/Build/AFNetworking/AFSecurityPolicy.h A cocoapods/Pods/Headers/Build/AFNetworking/AFURLConnectionOperation.h A cocoapods/Pods/Headers/Build/AFNetworking/AFURLRequestSerialization.h A cocoapods/Pods/Headers/Build/AFNetworking/AFURLResponseSerialization.h A cocoapods/Pods/Headers/Build/AFNetworking/AFURLSessionManager.h A cocoapods/Pods/Headers/Build/AFNetworking/UIActivityIndicatorView+AFNetworking.h A cocoapods/Pods/Headers/Build/AFNetworking/UIAlertView+AFNetworking.h A cocoapods/Pods/Headers/Build/AFNetworking/UIButton+AFNetworking.h A cocoapods/Pods/Headers/Build/AFNetworking/UIImageView+AFNetworking.h A cocoapods/Pods/Headers/Build/AFNetworking/UIKit+AFNetworking.h A cocoapods/Pods/Headers/Build/AFNetworking/UIProgressView+AFNetworking.h A cocoapods/Pods/Headers/Build/AFNetworking/UIRefreshControl+AFNetworking.h A cocoapods/Pods/Headers/Build/AFNetworking/UIWebView+AFNetworking.h A cocoapods/Pods/Headers/Build/hpple/TFHpple.h A cocoapods/Pods/Headers/Build/hpple/TFHppleElement.h A cocoapods/Pods/Headers/Build/hpple/XPathQuery.h A cocoapods/Pods/Headers/Public/AFNetworking/AFHTTPRequestOperation.h A cocoapods/Pods/Headers/Public/AFNetworking/AFHTTPRequestOperationManager.h A cocoapods/Pods/Headers/Public/AFNetworking/AFHTTPSessionManager.h A cocoapods/Pods/Headers/Public/AFNetworking/AFNetworkActivityIndicatorManager.h A cocoapods/Pods/Headers/Public/AFNetworking/AFNetworkReachabilityManager.h A cocoapods/Pods/Headers/Public/AFNetworking/AFNetworking.h A cocoapods/Pods/Headers/Public/AFNetworking/AFSecurityPolicy.h A cocoapods/Pods/Headers/Public/AFNetworking/AFURLConnectionOperation.h A cocoapods/Pods/Headers/Public/AFNetworking/AFURLRequestSerialization.h A cocoapods/Pods/Headers/Public/AFNetworking/AFURLResponseSerialization.h A cocoapods/Pods/Headers/Public/AFNetworking/AFURLSessionManager.h A cocoapods/Pods/Headers/Public/AFNetworking/UIActivityIndicatorView+AFNetworking.h A cocoapods/Pods/Headers/Public/AFNetworking/UIAlertView+AFNetworking.h A cocoapods/Pods/Headers/Public/AFNetworking/UIButton+AFNetworking.h A cocoapods/Pods/Headers/Public/AFNetworking/UIImageView+AFNetworking.h A cocoapods/Pods/Headers/Public/AFNetworking/UIKit+AFNetworking.h A cocoapods/Pods/Headers/Public/AFNetworking/UIProgressView+AFNetworking.h A cocoapods/Pods/Headers/Public/AFNetworking/UIRefreshControl+AFNetworking.h A cocoapods/Pods/Headers/Public/AFNetworking/UIWebView+AFNetworking.h A cocoapods/Pods/Headers/Public/hpple/TFHpple.h A cocoapods/Pods/Headers/Public/hpple/TFHppleElement.h A cocoapods/Pods/Headers/Public/hpple/XPathQuery.h A cocoapods/Pods/Manifest.lock A cocoapods/Pods/Pods.xcodeproj/project.pbxproj A cocoapods/Pods/Target Support Files/Pods-AFNetworking/Pods-AFNetworking-Private.xcconfig A cocoapods/Pods/Target Support Files/Pods-AFNetworking/Pods-AFNetworking-dummy.m A cocoapods/Pods/Target Support Files/Pods-AFNetworking/Pods-AFNetworking-prefix.pch A cocoapods/Pods/Target Support Files/Pods-AFNetworking/Pods-AFNetworking.xcconfig A cocoapods/Pods/Target Support Files/Pods-hpple/Pods-hpple-Private.xcconfig A cocoapods/Pods/Target Support Files/Pods-hpple/Pods-hpple-dummy.m A cocoapods/Pods/Target Support Files/Pods-hpple/Pods-hpple-prefix.pch A cocoapods/Pods/Target Support Files/Pods-hpple/Pods-hpple.xcconfig A cocoapods/Pods/Target Support Files/Pods/Pods-acknowledgements.markdown A cocoapods/Pods/Target Support Files/Pods/Pods-acknowledgements.plist A cocoapods/Pods/Target Support Files/Pods/Pods-dummy.m A cocoapods/Pods/Target Support Files/Pods/Pods-environment.h A cocoapods/Pods/Target Support Files/Pods/Pods-resources.sh A cocoapods/Pods/Target Support Files/Pods/Pods.debug.xcconfig A cocoapods/Pods/Target Support Files/Pods/Pods.release.xcconfig A cocoapods/Pods/hpple/LICENSE.txt A cocoapods/Pods/hpple/README.markdown R cocoapods/Pods/hpple/TFHpple.h A cocoapods/Pods/hpple/TFHpple.m R cocoapods/Pods/hpple/TFHppleElement.h R cocoapods/Pods/hpple/TFHppleElement.m A cocoapods/Pods/hpple/XPathQuery.h R cocoapods/Pods/hpple/XPathQuery.m A scripts/run-cocoapods.sh D wikipedia-tests/ArticleDataModel.m D wikipedia-tests/CommunicationBridgeTests.m D wikipedia-tests/NetworkOpCrumbyTests.m D wikipedia-tests/NetworkOpTests.m D wikipedia-tests/SiteTests.m D wikipedia-tests/Wikipedia-Tests-Info.plist D wikipedia-tests/Wikipedia_Tests.m D wikipedia-tests/en.lproj/InfoPlist.strings D wikipedia-tests/mw-support/PageTitleTests.m M wikipedia/AssetsFile/AssetsFile.m M wikipedia/Base.lproj/Main_iPhone.storyboard M wikipedia/Categories/NSObject+Extras.h M wikipedia/Categories/NSObject+Extras.m M wikipedia/Categories/NSURLRequest+DictionaryRequest.m M wikipedia/Data/Model/Article.h M wikipedia/Data/Model/Article.m D wikipedia/Data/Operations/AccountCreationOp.h D wikipedia/Data/Operations/AccountCreationOp.m D wikipedia/Data/Operations/AccountCreationTokenOp.h D wikipedia/Data/Operations/AccountCreationTokenOp.m D wikipedia/Data/Operations/CaptchaResetOp.h D wikipedia/Data/Operations/CaptchaResetOp.m D wikipedia/Data/Operations/DownloadLangLinksOp.h D wikipedia/Data/Operations/DownloadLangLinksOp.m D wikipedia/Data/Operations/DownloadSectionWikiTextOp.h D wikipedia/Data/Operations/DownloadSectionWikiTextOp.m D wikipedia/Data/Operations/DownloadSectionsOp.h D wikipedia/Data/Operations/DownloadSectionsOp.m D wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.h D wikipedia/Data/Operations/DownloadTitlesForRandomArticlesOp.m D wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.h D wikipedia/Data/Operations/DownloadWikipediaZeroMessageOp.m D wikipedia/Data/Operations/EditTokenOp.h D wikipedia/Data/Operations/EditTokenOp.m D wikipedia/Data/Operations/LogEventOp.h D wikipedia/Data/Operations/LogEventOp.m D wikipedia/Data/Operations/LoginOp.h D wikipedia/Data/Operations/LoginOp.m D wikipedia/Data/Operations/LoginTokenOp.h D wikipedia/Data/Operations/LoginTokenOp.m D wikipedia/Data/Operations/NearbyOp.h D wikipedia/Data/Operations/NearbyOp.m D wikipedia/Data/Operations/PageHistoryOp.h D wikipedia/Data/Operations/PageHistoryOp.m D wikipedia/Data/Operations/PreviewWikiText.h D wikipedia/Data/Operations/PreviewWikiText.m D wikipedia/Data/Operations/PreviewWikiTextOp.h D wikipedia/Data/Operations/PreviewWikiTextOp.m D wikipedia/Data/Operations/SearchOp.h D wikipedia/Data/Operations/SearchOp.m D wikipedia/Data/Operations/SyncAssetsFileOp.h D wikipedia/Data/Operations/SyncAssetsFileOp.m D wikipedia/Data/Operations/UploadSectionWikiTextOp.h D wikipedia/Data/Operations/UploadSectionWikiTextOp.m A wikipedia/EventLogging/EventLogger.h A wikipedia/EventLogging/EventLogger.m M wikipedia/EventLogging/EventLoggingFunnel.m D wikipedia/HTML Parsing/hpple/TFHpple.m D wikipedia/HTML Parsing/hpple/XPathQuery.h A wikipedia/Networking/Fetchers/AccountCreationTokenFetcher.h A wikipedia/Networking/Fetchers/AccountCreationTokenFetcher.m A wikipedia/Networking/Fetchers/AccountCreator.h A wikipedia/Networking/Fetchers/AccountCreator.m A wikipedia/Networking/Fetchers/AccountLogin.h A wikipedia/Networking/Fetchers/AccountLogin.m A wikipedia/Networking/Fetchers/ArticleFetcher.h A wikipedia/Networking/Fetchers/ArticleFetcher.m A wikipedia/Networking/Fetchers/AssetsFileFetcher.h A wikipedia/Networking/Fetchers/AssetsFileFetcher.m A wikipedia/Networking/Fetchers/BaseFetcher/FetcherBase.h A wikipedia/Networking/Fetchers/BaseFetcher/FetcherBase.m A wikipedia/Networking/Fetchers/CaptchaResetter.h A wikipedia/Networking/Fetchers/CaptchaResetter.m A wikipedia/Networking/Fetchers/EditTokenFetcher.h A wikipedia/Networking/Fetchers/EditTokenFetcher.m A wikipedia/Networking/Fetchers/LanguageLinksFetcher.h A wikipedia/Networking/Fetchers/LanguageLinksFetcher.m A wikipedia/Networking/Fetchers/LoginTokenFetcher.h A wikipedia/Networking/Fetchers/LoginTokenFetcher.m A wikipedia/Networking/Fetchers/NearbyFetcher.h A wikipedia/Networking/Fetchers/NearbyFetcher.m A wikipedia/Networking/Fetchers/PageHistoryFetcher.h A wikipedia/Networking/Fetchers/PageHistoryFetcher.m A wikipedia/Networking/Fetchers/PreviewHtmlFetcher.h A wikipedia/Networking/Fetchers/PreviewHtmlFetcher.m A wikipedia/Networking/Fetchers/RandomArticleFetcher.h A wikipedia/Networking/Fetchers/RandomArticleFetcher.m A wikipedia/Networking/Fetchers/SearchResultFetcher.h A wikipedia/Networking/Fetchers/SearchResultFetcher.m A wikipedia/Networking/Fetchers/ThumbnailFetcher.h A wikipedia/Networking/Fetchers/ThumbnailFetcher.m A wikipedia/Networking/Fetchers/WikiTextSectionFetcher.h A wikipedia/Networking/Fetchers/WikiTextSectionFetcher.m A wikipedia/Networking/Fetchers/WikiTextSectionUploader.h A wikipedia/Networking/Fetchers/WikiTextSectionUploader.m A wikipedia/Networking/Fetchers/WikipediaZeroMessageFetcher.h A wikipedia/Networking/Fetchers/WikipediaZeroMessageFetcher.m A wikipedia/Networking/Queues/QueuesSingleton.h A wikipedia/Networking/Queues/QueuesSingleton.m D wikipedia/Queues/QueuesSingleton.h D wikipedia/Queues/QueuesSingleton.m M wikipedia/View Controllers/AccountCreation/AccountCreationViewController.h M wikipedia/View Controllers/AccountCreation/AccountCreationViewController.m M wikipedia/View Controllers/Credits/CreditsViewController.m M wikipedia/View Controllers/Languages/LanguagesViewController.h M wikipedia/View Controllers/Languages/LanguagesViewController.m M wikipedia/View Controllers/Login/LoginViewController.h M wikipedia/View Controllers/Login/LoginViewController.m M wikipedia/View Controllers/Navigation/Center/CenterNavController.h M wikipedia/View Controllers/Navigation/Center/CenterNavController.m M wikipedia/View Controllers/Navigation/Primary/PrimaryMenuViewController.h M wikipedia/View Controllers/Navigation/Primary/PrimaryMenuViewController.m M wikipedia/View Controllers/Nearby/NearbyViewController.h M wikipedia/View Controllers/Nearby/NearbyViewController.m M wikipedia/View Controllers/PageHistory/PageHistoryViewController.h M wikipedia/View Controllers/PageHistory/PageHistoryViewController.m M wikipedia/View Controllers/Preview/PreviewAndSaveViewController.h M wikipedia/View Controllers/Preview/PreviewAndSaveViewController.m M wikipedia/View Controllers/References/ReferenceVC.m M wikipedia/View Controllers/SearchResults/SearchResultsController.h M wikipedia/View Controllers/SearchResults/SearchResultsController.m M wikipedia/View Controllers/SectionEditor/SectionEditorViewController.h M wikipedia/View Controllers/SectionEditor/SectionEditorViewController.m M wikipedia/View Controllers/WebView/WebViewController.h M wikipedia/View Controllers/WebView/WebViewController.m M wikipedia/assets/abusefilter.css M wikipedia/assets/preview.css M wikipedia/assets/styles.css D wikipedia/mw-crumbtest/MWCrumbyTest.h D wikipedia/mw-crumbtest/MWCrumbyTest.m D wikipedia/mw-network/MWNetworkOp.h D wikipedia/mw-network/MWNetworkOp.m 246 files changed, 18,559 insertions(+), 5,641 deletions(-) Approvals: Brion VIBBER: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/168191 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I991fac86a8788d3fd25595849b618a3d1ee7e699 Gerrit-PatchSet: 7 Gerrit-Project: apps/ios/wikipedia Gerrit-Branch: master Gerrit-Owner: Mhurd <mh...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Mhurd <mh...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
