jenkins-bot has submitted this change and it was merged.
Change subject: Fix edit section icon regression
......................................................................
Fix edit section icon regression
Bug: 72484
Change-Id: Id3cbfbe5fd041781ef6ce1e9346d69e8978fafed
---
M includes/skins/SkinMinerva.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Florianschmidtwelzow: Looks good to me, but someone else must approve
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 773cbb2..e3bd29e 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -154,7 +154,9 @@
'href' => '#/editor/' . $section,
'title' => wfMessage( 'editsectionhint',
$tooltip )->inLanguage( $lang ),
'data-section' => $section,
- 'class' => MobileUI::iconClass( 'edit',
'element', 'edit-page enabled icon-32px' ),
+ // Note visibility of the edit section link
button is controlled by .edit-page in ui.less so
+ // we default to enabled even though this may
not be true.
+ 'class' => MobileUI::iconClass( 'edit-enabled',
'element', 'edit-page icon-32px' ),
), $message );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/168637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3cbfbe5fd041781ef6ce1e9346d69e8978fafed
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
