jenkins-bot has submitted this change and it was merged.
Change subject: Fixed wrong checks for undefined in QUnit tests
......................................................................
Fixed wrong checks for undefined in QUnit tests
Change-Id: I808828b46f8c35eb1e3698bfa9a247eef90b02b5
---
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
5 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
index 33441db..8247cec 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
@@ -65,7 +65,7 @@
descriptionview = $descriptionview.data( 'descriptionview' );
assert.ok(
- descriptionview !== 'undefined',
+ descriptionview instanceof $.wikibase.descriptionview,
'Created widget.'
);
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
index bff407d..af26922 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
@@ -66,7 +66,7 @@
entityview = $entityview.data( 'entityview' );
assert.ok(
- entityview !== 'undefined',
+ entityview instanceof $.wikibase.entityview,
'Created widget.'
);
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
index bac0897..0d8cb5d 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
@@ -65,7 +65,7 @@
labelview = $labelview.data( 'labelview' );
assert.ok(
- labelview !== 'undefined',
+ labelview instanceof $.wikibase.labelview,
'Created widget.'
);
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
index a6495ea..50fd132 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
@@ -87,8 +87,8 @@
sitelinklistview = $sitelinklistview.data( 'sitelinklistview' );
assert.ok(
- sitelinklistview !== 'undefined',
- 'Created widget'
+ sitelinklistview instanceof $.wikibase.sitelinklistview,
+ 'Created widget.'
);
sitelinklistview.destroy();
@@ -107,8 +107,8 @@
sitelinklistview = $sitelinklistview.data( 'sitelinklistview' );
assert.ok(
- sitelinklistview !== 'undefined',
- 'Created widget'
+ sitelinklistview instanceof $.wikibase.sitelinklistview,
+ 'Created widget.'
);
sitelinklistview.destroy();
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
index 2dcad0a..1ccd4ee 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
@@ -73,8 +73,8 @@
sitelinkview = $sitelinkview.data( 'sitelinkview' );
assert.ok(
- sitelinkview !== 'undefined',
- 'Created widget'
+ sitelinkview instanceof $.wikibase.sitelinkview,
+ 'Created widget.'
);
sitelinkview.destroy();
@@ -93,8 +93,8 @@
sitelinkview = $sitelinkview.data( 'sitelinkview' );
assert.ok(
- sitelinkview !== 'undefined',
- 'Created widget'
+ sitelinkview instanceof $.wikibase.sitelinkview,
+ 'Created widget.'
);
sitelinkview.destroy();
--
To view, visit https://gerrit.wikimedia.org/r/167570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I808828b46f8c35eb1e3698bfa9a247eef90b02b5
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
