Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/168962

Change subject: Remove meaningless default action name
......................................................................

Remove meaningless default action name

Before: Get the value of the action=... parameter. If it's undefined
return 'view'. Check if 'view' equals 'ajax'.

After: Get the value of the action=... parameter. If it's undefined
return null. Check if null equals 'ajax'.

Change-Id: I56656218cfb895bffe886919c67ebf3b79d91515
---
M includes/MediaWiki.php
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/62/168962/1

diff --git a/includes/MediaWiki.php b/includes/MediaWiki.php
index 9585c5f..107208e 100644
--- a/includes/MediaWiki.php
+++ b/includes/MediaWiki.php
@@ -489,8 +489,7 @@
                $request = $this->context->getRequest();
 
                // Send Ajax requests to the Ajax dispatcher.
-               if ( $this->config->get( 'UseAjax' ) && $request->getVal( 
'action', 'view' ) == 'ajax' ) {
-
+               if ( $this->config->get( 'UseAjax' ) && $request->getVal( 
'action' ) === 'ajax' ) {
                        // Set a dummy title, because $wgTitle == null might 
break things
                        $title = Title::makeTitle( NS_MAIN, 'AJAX' );
                        $this->context->setTitle( $title );

-- 
To view, visit https://gerrit.wikimedia.org/r/168962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56656218cfb895bffe886919c67ebf3b79d91515
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to