jenkins-bot has submitted this change and it was merged.
Change subject: Limit Echo mentions to 20 users
......................................................................
Limit Echo mentions to 20 users
Bug: 50082
Change-Id: I7eb0f41fc9b0e3a396383a1adaecf51dc883217f
---
M includes/DiscussionParser.php
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/DiscussionParser.php b/includes/DiscussionParser.php
index 381b395..cbd2f5b 100644
--- a/includes/DiscussionParser.php
+++ b/includes/DiscussionParser.php
@@ -174,9 +174,10 @@
}
$mentionedUsers[$user->getId()] = $user->getId();
$count++;
- // This is an unbounded list, put a cap on the
allowable mentioned user list
- if ( $count > 100 ) {
- break;
+ // If more than 20 users are being pinged this is
likely a spam/attack vector
+ // Don't send any mention notifications.
+ if ( $count > 20 ) {
+ return;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/159800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7eb0f41fc9b0e3a396383a1adaecf51dc883217f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
