jenkins-bot has submitted this change and it was merged.
Change subject: Add test for EditorOverlay preview
......................................................................
Add test for EditorOverlay preview
... to prevent, that a missing preview happens again.
Change-Id: I2289db7369f9c568a114ee491decaeae0a8ed6e0
---
M tests/qunit/modules/editor/test_EditorOverlay.js
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/qunit/modules/editor/test_EditorOverlay.js
b/tests/qunit/modules/editor/test_EditorOverlay.js
index 1772a65..0109bf7 100644
--- a/tests/qunit/modules/editor/test_EditorOverlay.js
+++ b/tests/qunit/modules/editor/test_EditorOverlay.js
@@ -12,6 +12,8 @@
this.sandbox.stub( EditorOverlay.prototype, 'log'
).returns( $.Deferred().resolve() );
this.sandbox.stub( EditorApi.prototype, 'getContent' ).
returns( $.Deferred().resolve( 'section 0' ) );
+ this.sandbox.stub( EditorApi.prototype, 'getPreview' ).
+ returns( $.Deferred().resolve( 'previewtest' )
);
}
} );
@@ -23,6 +25,13 @@
assert.strictEqual( editorOverlay.$content.val(), 'section 0',
'load correct section' );
} );
+ QUnit.test( '#preview', 1, function( assert ) {
+ var editorOverlay = new EditorOverlay( { title: 'test',
sectionId: 0 } );
+
+ editorOverlay._prepareForSave();
+ assert.strictEqual( editorOverlay.$preview.text(),
'\npreviewtest\n', 'preview loaded correctly' );
+ } );
+
QUnit.test( '#initialize, without a section', 2, function( assert ) {
new EditorOverlay( { title: 'test.css' } );
--
To view, visit https://gerrit.wikimedia.org/r/169211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2289db7369f9c568a114ee491decaeae0a8ed6e0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
