Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169266

Change subject: apache: reload when config changes (bugfix)
......................................................................

apache: reload when config changes (bugfix)

Apparently the Apache module's intention is to reload apache when config
changes. However, right now there is a notify => Service only on the
$conf-enabled path, which is actually the symlink; while this works for
an initial provisioning, it does not work for config *contents* changes,
as the symlink does not get modified at all. Add a notify to the
$conf-available path as well to address this.

Change-Id: I7cd7f306161b8d92e1c22825be9a81c87333c77c
---
M modules/apache/manifests/conf.pp
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/66/169266/1

diff --git a/modules/apache/manifests/conf.pp b/modules/apache/manifests/conf.pp
index 0b5aab9..448dabc 100644
--- a/modules/apache/manifests/conf.pp
+++ b/modules/apache/manifests/conf.pp
@@ -73,6 +73,7 @@
         owner   => 'root',
         group   => 'root',
         mode    => '0444',
+        notify  => Service['apache2'],
     }
 
     file { "/etc/apache2/${conf_type}-enabled/${conf_file}":

-- 
To view, visit https://gerrit.wikimedia.org/r/169266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cd7f306161b8d92e1c22825be9a81c87333c77c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to