Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169279
Change subject: [BREAKING CHANGE] Apply font-size: 0.8em; to non-isolated
windows too
......................................................................
[BREAKING CHANGE] Apply font-size: 0.8em; to non-isolated windows too
The Apex and MediaWiki themes applied it to isolated windows and overlays,
but not non-isolated windows. This is difficult for integrations
to work around, because applying font-size: 0.8em to non-isolated
window managers will cause the overlays' font size to be 0.64em.
Instead, just remove this ridiculous exception.
Change-Id: Id25907c4c41b72c879e4010208ed66a3580374ad
---
M demos/pages/dialogs.js
M src/themes/apex/windows.less
M src/themes/mediawiki/windows.less
3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/79/169279/1
diff --git a/demos/pages/dialogs.js b/demos/pages/dialogs.js
index f2ea0b8..ceeb1e7 100644
--- a/demos/pages/dialogs.js
+++ b/demos/pages/dialogs.js
@@ -372,7 +372,7 @@
windowManager.addWindows( windows );
isolatedWindowManager.addWindows( isolatedWindows );
- $demo.append( $( '<div class="oo-ui-demo-container"></div>' ).append(
- fieldset.$element, windowManager.$element,
isolatedWindowManager.$element
- ) );
+ $demo.append( $( '<div class="oo-ui-demo-container"></div>' ).append(
fieldset.$element ),
+ windowManager.$element, isolatedWindowManager.$element
+ );
};
diff --git a/src/themes/apex/windows.less b/src/themes/apex/windows.less
index 0b11e3f..a8edbfa 100644
--- a/src/themes/apex/windows.less
+++ b/src/themes/apex/windows.less
@@ -1,8 +1,8 @@
@import 'common';
.theme-oo-ui-window () {
- &-isolated,
- &-overlay {
+ &,
+ &-isolated {
background-color: transparent;
background-image: none;
font-family: sans-serif;
diff --git a/src/themes/mediawiki/windows.less
b/src/themes/mediawiki/windows.less
index d7c5ed2..84b7dff 100644
--- a/src/themes/mediawiki/windows.less
+++ b/src/themes/mediawiki/windows.less
@@ -1,8 +1,8 @@
@import 'common';
.theme-oo-ui-window () {
- &-isolated,
- &-overlay {
+ &,
+ &-isolated {
background: transparent;
font-family: sans-serif;
font-size: 0.8em;
--
To view, visit https://gerrit.wikimedia.org/r/169279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id25907c4c41b72c879e4010208ed66a3580374ad
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
