jenkins-bot has submitted this change and it was merged.
Change subject: Show namespace field description next to the field and remove
it from placeholder
......................................................................
Show namespace field description next to the field and remove it from
placeholder
Bug: 71582
Change-Id: Iac76cb23dbefdd9230e2ad9a7f5a99d6970afe14
---
M wikimetrics/templates/forms/metric_configuration.html
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Nuria: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikimetrics/templates/forms/metric_configuration.html
b/wikimetrics/templates/forms/metric_configuration.html
index b8c91f7..804c98d 100644
--- a/wikimetrics/templates/forms/metric_configuration.html
+++ b/wikimetrics/templates/forms/metric_configuration.html
@@ -20,7 +20,10 @@
</span>
</div>
{% else %}
- {{ f(placeholder=f.description, **{'data-bind':'value:
'+f.name}) }}
+ {{ f(**{'data-bind':'value: '+f.name}) }}
+ {% if f.name == 'namespaces' %}
+ {{ f.description }}
+ {% endif %}
{% endif %}
{% if f.type == 'CommaSeparatedIntegerListField' %}(comma
separated){% endif %}
{{ validation.messages(f) }}
--
To view, visit https://gerrit.wikimedia.org/r/168202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac76cb23dbefdd9230e2ad9a7f5a99d6970afe14
Gerrit-PatchSet: 3
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Mforns <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
Gerrit-Reviewer: Nuria <[email protected]>
Gerrit-Reviewer: QChris <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
