Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169317

Change subject: Hygeine: Remove stub/unused links
......................................................................

Hygeine: Remove stub/unused links

* There are no search links anywhere.
* We don't support pagination within a topic.
* TopicList has pagination has pagination, but the previous field
  was a stub; it is set elsewhere in the class.

Change-Id: I0143455e54e14d2ddebb234c4d2758ee6a2c581d
---
M includes/Formatter/TopicFormatter.php
M includes/Formatter/TopicListFormatter.php
2 files changed, 1 insertion(+), 25 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/17/169317/1

diff --git a/includes/Formatter/TopicFormatter.php 
b/includes/Formatter/TopicFormatter.php
index 258a3db..76bf8af 100644
--- a/includes/Formatter/TopicFormatter.php
+++ b/includes/Formatter/TopicFormatter.php
@@ -74,18 +74,6 @@
                        'roots' => $roots,
                        'posts' => $posts,
                        'revisions' => $revisions,
-                       'links' => array(
-                               'search' => array(
-                                       'url' => '',
-                                       'title' => '',
-                               ),
-                               'pagination' => array(
-                                       'load_more' => array(
-                                               'url' => '',
-                                               'title' => '',
-                                       ),
-                               ),
-                       ),
                ) + $this->getEmptyResult( $listWorkflow );
        }
 
diff --git a/includes/Formatter/TopicListFormatter.php 
b/includes/Formatter/TopicListFormatter.php
index 169c470..20fd0d4 100644
--- a/includes/Formatter/TopicListFormatter.php
+++ b/includes/Formatter/TopicListFormatter.php
@@ -37,7 +37,7 @@
                        'roots' => array(),
                        'posts' => array(),
                        'revisions' => array(),
-                       'links' => array( 'pagination' => array() ),
+                       'links' => array(),
                        'actions' => $this->buildApiActions( $workflow ),
                        'submitted' => array(),
                );
@@ -142,18 +142,6 @@
                        'roots' => $list,
                        'posts' => $posts,
                        'revisions' => $revisions,
-                       'links' => array(
-                               'search' => array(
-                                       'url' => '',
-                                       'title' => '',
-                               ),
-                               'pagination' => array(
-                                       'load_more' => array(
-                                               'url' => '',
-                                               'title' => '',
-                                       ),
-                               ),
-                       ),
                );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/169317
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0143455e54e14d2ddebb234c4d2758ee6a2c581d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to