PleaseStand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169323

Change subject: ApiHelp: Fix PHP notice when "wrap" parameter is provided
......................................................................

ApiHelp: Fix PHP notice when "wrap" parameter is provided

An incorrect variable name was used, so the "help" property of
the "help" object in the output was merely encoded as null.

Change-Id: Ia1a8c8ad4515e216998d4975aad3555f87d24380
---
M includes/api/ApiHelp.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/23/169323/1

diff --git a/includes/api/ApiHelp.php b/includes/api/ApiHelp.php
index 9be2d92..88a3df2 100644
--- a/includes/api/ApiHelp.php
+++ b/includes/api/ApiHelp.php
@@ -60,7 +60,7 @@
                if ( $params['wrap'] ) {
                        $data = array(
                                'mime' => 'text/html',
-                               'help' => $help,
+                               'help' => $html,
                        );
                        $result->setSubelements( $data, 'help' );
                        $result->addValue( null, $this->getModuleName(), $data 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/169323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1a8c8ad4515e216998d4975aad3555f87d24380
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to