Robert Vogel has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169338
Change subject: Fixed MaximizablePanel in Chrome
......................................................................
Fixed MaximizablePanel in Chrome
In Chrome the contents of the Ext.Window derived panel where overlapped
after a 'maximize' command. One had to click on the hidden elements to
reveal them.
The panel no longer gets rendered to the element provided in the
'renderTo' config, but always to the body element. All size and position
operations are still made on 'renderTo'.
Still missing: appropriate behavior on viewport resize.
Change-Id: I566854f49f9a4bdeb5a61249c6c99f72f28ed43d
---
M PermissionManager/resources/BS.panel/Maximizable.js
1 file changed, 21 insertions(+), 9 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/38/169338/1
diff --git a/PermissionManager/resources/BS.panel/Maximizable.js
b/PermissionManager/resources/BS.panel/Maximizable.js
index 068246d..d0e92f2 100644
--- a/PermissionManager/resources/BS.panel/Maximizable.js
+++ b/PermissionManager/resources/BS.panel/Maximizable.js
@@ -4,11 +4,23 @@
shadow: false,
closable: false,
border: false,
+
oldX: 0,
oldY: 0,
+ bsRenderToTarget: null,
+
+ constructor: function( cfg ) {
+ this.bsRenderToTarget = Ext.get(cfg.renderTo);
+
+ cfg.height = cfg.height || this.bsRenderToTarget.getHeight();
+ cfg.width = cfg.width || this.bsRenderToTarget.getWidth();
+
+ cfg.renderTo = Ext.getBody();
+
+ this.callParent( arguments );
+ },
+
initComponent: function() {
- this.height = Ext.get(this.renderTo).getHeight();
- this.width = Ext.get(this.renderTo).getWidth();
this.maximizeTool = new Ext.panel.Tool({
type: 'maximize'
});
@@ -30,22 +42,22 @@
this.callParent(arguments);
},
onAfterRender: function(sender, eOpts) {
- this.showAt(sender.container.getXY());
+ this.showAt(this.bsRenderToTarget.getXY());
},
onMaximizeToolClick: function() {
- Ext.get(this.renderTo).addCls('fullscreen');
+ this.bsRenderToTarget.addCls('fullscreen');
this.updateSize();
this.maximizeTool.setVisible(false);
this.minimizeTool.setVisible(true);
- this.showAt(Ext.get(this.renderTo).getXY());
+ this.showAt(this.bsRenderToTarget.getXY());
},
onMinimizeToolClick: function() {
- Ext.get(this.renderTo).removeCls('fullscreen');
+ this.bsRenderToTarget.removeCls('fullscreen');
this.updateSize();
this.maximizeTool.setVisible(true);
this.minimizeTool.setVisible(false);
- this.showAt(Ext.get(this.renderTo).getXY());
+ this.showAt(this.bsRenderToTarget.getXY());
},
firstCall: true,
showAt: function(x, y) {
@@ -57,7 +69,7 @@
this.callParent(arguments);
},
updateSize: function() {
- this.setHeight(Ext.get(this.renderTo).getHeight());
- this.setWidth(Ext.get(this.renderTo).getWidth());
+ this.setHeight(this.bsRenderToTarget.getHeight());
+ this.setWidth(this.bsRenderToTarget.getWidth());
}
});
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/169338
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I566854f49f9a4bdeb5a61249c6c99f72f28ed43d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_22
Gerrit-Owner: Robert Vogel <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
