Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/169360
Change subject: Remove bad dependency from NoBadDependencyUsageTest ...................................................................... Remove bad dependency from NoBadDependencyUsageTest Much irony Change-Id: I3e851aadde8e6e21066f38d979ddd61d6925f928 --- M lib/tests/phpunit/NoBadDependencyUsageTest.php 1 file changed, 0 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/60/169360/1 diff --git a/lib/tests/phpunit/NoBadDependencyUsageTest.php b/lib/tests/phpunit/NoBadDependencyUsageTest.php index b33e3d0..d0ec71c 100644 --- a/lib/tests/phpunit/NoBadDependencyUsageTest.php +++ b/lib/tests/phpunit/NoBadDependencyUsageTest.php @@ -26,31 +26,10 @@ $this->assertStringNotInLib( 'Wikibase\\Client\\', 3 ); } - public function testNoSettingsUsageOutsideLib() { - // Increasing this allowance is forbidden - $this->assertStringNotInRepo( 'Settings::', 1 ); - $this->assertStringNotInClient( 'Settings::', 1 ); - } - private function assertStringNotInLib( $string, $maxAllowance ) { $this->assertStringNotInDir( $string, __DIR__ . '/../../', - $maxAllowance - ); - } - private function assertStringNotInClient( $string, $maxAllowance ) { - $this->assertStringNotInDir( - $string, - __DIR__ . '/../../../client/', - $maxAllowance - ); - } - - private function assertStringNotInRepo( $string, $maxAllowance ) { - $this->assertStringNotInDir( - $string, - __DIR__ . '/../../../repo/', $maxAllowance ); } -- To view, visit https://gerrit.wikimedia.org/r/169360 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3e851aadde8e6e21066f38d979ddd61d6925f928 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits