Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169363
Change subject: Fixed Lint/UnusedBlockArgument RuboCop offense
......................................................................
Fixed Lint/UnusedBlockArgument RuboCop offense
Change-Id: Ic17fa0f6b3c2af0a4c3e75f6c847a6c033029b03
Paired-With: Amir Aharoni
Bug: 63307
---
M .rubocop_todo.yml
M tests/browser/features/step_definitions/special_content_translation_steps.rb
2 files changed, 3 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/63/169363/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 3efff31..70fdca6 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -9,11 +9,6 @@
Lint/AmbiguousRegexpLiteral:
Enabled: false
-# Offense count: 4
-# Cop supports --auto-correct.
-Lint/UnusedBlockArgument:
- Enabled: false
-
# Offense count: 36
# Configuration parameters: AllowURI, URISchemes.
Metrics/LineLength:
diff --git
a/tests/browser/features/step_definitions/special_content_translation_steps.rb
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
index 6aaf192..ff5704a 100644
---
a/tests/browser/features/step_definitions/special_content_translation_steps.rb
+++
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
@@ -1,4 +1,4 @@
-Given(/^I am on the content translation page in a wiki in (.+?), translating
the page "(.+?)" to (.+?)$/) do |source_language, page_name, target_language|
+Given(/^I am on the content translation page in a wiki in (.+?), translating
the page "(.+?)" to (.+?)$/) do |_source_language, page_name, target_language|
language_code = {
"Danish" => "da",
"English" => "en",
@@ -31,7 +31,7 @@
on(ContentTranslationPage).column(column_type).should_not exist
end
-Then(/^I see a "(.*?)" link that points to the page "(.*?)" on the same
wiki$/) do |link_name, page_title|
+Then(/^I see a "(.*?)" link that points to the page "(.*?)" on the same
wiki$/) do |_link_name, page_title|
page_title_in_url = page_title.gsub(" ", "_")
on(ContentTranslationPage).view_page.attribute_value("href").should
end_with(page_title_in_url)
end
@@ -96,7 +96,7 @@
on(ContentTranslationPage).column(column_type).attribute_value("dir").should ==
direction
end
-Then(/^the first version in the history of the page "(.+?)" should have the
tag "(.+?)"$/) do |page_title, tag_name|
+Then(/^the first version in the history of the page "(.+?)" should have the
tag "(.+?)"$/) do |_page_title, _tag_name|
visit(TranslatedPageHistory).contenttranslation_tag_element.should
be_visible
end
--
To view, visit https://gerrit.wikimedia.org/r/169363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic17fa0f6b3c2af0a4c3e75f6c847a6c033029b03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
