Nikerabbit has submitted this change and it was merged. Change subject: Stash global only once per test case. ......................................................................
Stash global only once per test case. Make sure we only stash a given global only once per test case since we do not want to override the original value. This allows the same test to modify the same global multiple times, while still preserving the original value to be restored after the test case finished. Change-Id: I9056d6d6879fb976a192960f661904287f9760a8 --- M tests/phpunit/MediaWikiTestCase.php 1 file changed, 14 insertions(+), 7 deletions(-) Approvals: Aude: Looks good to me, but someone else must approve Nikerabbit: Looks good to me, approved Daniel Kinzler: Looks good to me, but someone else must approve Hashar: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29972 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9056d6d6879fb976a192960f661904287f9760a8 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
