jenkins-bot has submitted this change and it was merged.
Change subject: Put icons back in template parameter search
......................................................................
Put icons back in template parameter search
These disappeared when DecoratedOptionWidget was split
out of OptionWidget in I508c1555 in oojs-ui back in July,
and apparently no one noticed.
Make MWParameterResultWidget and MWMoreParameterResultWidget
inherit DecoratedOptionWidget instead of OptionWidget so
the icon config parameter is recognized again.
Change-Id: I08d8a0466c211a29eb62043131725073dece4eb5
---
M modules/ve-mw/ui/widgets/ve.ui.MWMoreParametersResultWidget.js
M modules/ve-mw/ui/widgets/ve.ui.MWParameterResultWidget.js
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWMoreParametersResultWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWMoreParametersResultWidget.js
index a588b3e..f577c78 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWMoreParametersResultWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWMoreParametersResultWidget.js
@@ -9,7 +9,7 @@
* Creates an ve.ui.MWMoreParametersResultWidget object.
*
* @class
- * @extends OO.ui.OptionWidget
+ * @extends OO.ui.DecoratedOptionWidget
*
* @constructor
* @param {Mixed} data Item data
@@ -21,7 +21,7 @@
config = ve.extendObject( { icon: 'parameter-set' }, config );
// Parent constructor
- OO.ui.OptionWidget.call( this, data, config );
+ OO.ui.DecoratedOptionWidget.call( this, data, config );
// Initialization
this.$element.addClass( 've-ui-mwMoreParametersResultWidget' );
@@ -30,7 +30,7 @@
/* Inheritance */
-OO.inheritClass( ve.ui.MWMoreParametersResultWidget, OO.ui.OptionWidget );
+OO.inheritClass( ve.ui.MWMoreParametersResultWidget,
OO.ui.DecoratedOptionWidget );
/* Methods */
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWParameterResultWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWParameterResultWidget.js
index 6bc355c..7fa162d 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWParameterResultWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWParameterResultWidget.js
@@ -9,7 +9,7 @@
* Creates an ve.ui.MWParameterResultWidget object.
*
* @class
- * @extends OO.ui.OptionWidget
+ * @extends OO.ui.DecoratedOptionWidget
*
* @constructor
* @param {Mixed} data Item data
@@ -20,7 +20,7 @@
config = ve.extendObject( { icon: 'parameter' }, config );
// Parent constructor
- OO.ui.OptionWidget.call( this, data, config );
+ OO.ui.DecoratedOptionWidget.call( this, data, config );
// Initialization
this.$element.addClass( 've-ui-mwParameterResultWidget' );
@@ -29,7 +29,7 @@
/* Inheritance */
-OO.inheritClass( ve.ui.MWParameterResultWidget, OO.ui.OptionWidget );
+OO.inheritClass( ve.ui.MWParameterResultWidget, OO.ui.DecoratedOptionWidget );
/* Methods */
--
To view, visit https://gerrit.wikimedia.org/r/169293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08d8a0466c211a29eb62043131725073dece4eb5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
