[MediaWiki-commits] [Gerrit] WIP: Get tap event to work without window.addEventListener - change (mediawiki...MobileFrontend)

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169553

Change subject: WIP: Get tap event to work without window.addEventListener
......................................................................

WIP: Get tap event to work without window.addEventListener

Bug: 72566
Change-Id: Ib10f0764f7a81dd57b44d4249fb24b8eb9fb7be2
---
M javascripts/externals/micro.tap.js
1 file changed, 17 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/53/169553/1

diff --git a/javascripts/externals/micro.tap.js 
b/javascripts/externals/micro.tap.js
index a3f05b7..1caf1d3 100644
--- a/javascripts/externals/micro.tap.js
+++ b/javascripts/externals/micro.tap.js
@@ -11,18 +11,26 @@
   var $window = $(window), moved, tapEv;
 
   function handleTap(ev) {
+    var target = ev.target ? ev.target : ev.srcElement;
     tapEv = $.Event('tap');
-    if (!moved) $(ev.target).trigger(tapEv);
+    if (!moved) {
+      $(target).trigger(tapEv);
+    }
   }
 
-  // FIXME: jQuery's on() doesn't allow useCapture argument (last argument, 
true)
-  window.addEventListener('click', function (ev) {
+  function handler(ev) {
     // a tap event might be fired programmatically so ensure tapEv has been 
defined
     if (tapEv && tapEv.isDefaultPrevented()) {
       ev.stopPropagation();
       ev.preventDefault();
     }
-  }, true);
+  }
+  // FIXME: jQuery's on() doesn't allow useCapture argument (last argument, 
true)
+  if (window.addEventListener) {
+    window.addEventListener('click', handler, true);
+  } else if (document.attachEvent){
+    document.attachEvent('onclick', handler);
+  }
 
   if ('ontouchstart' in window) {
     $window.
@@ -35,7 +43,11 @@
       on('touchend', handleTap);
   } else {
     // FIXME: jQuery's on() doesn't allow useCapture argument (last argument, 
true)
-    window.addEventListener('mouseup', handleTap, true);
+    if (window.addEventListener) {
+      window.addEventListener('mouseup', handleTap, true);
+    } else if (document.attachEvent){
+      document.attachEvent('onmouseup', handleTap);
+    }
   }
 }(jQuery));
 

-- 
To view, visit https://gerrit.wikimedia.org/r/169553
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib10f0764f7a81dd57b44d4249fb24b8eb9fb7be2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits