Dzahn has submitted this change and it was merged. Change subject: firewall: nitpicks ......................................................................
firewall: nitpicks Change-Id: I2e572e7aa5f60987f5e5329baf1c827aca45d3fd --- M manifests/misc/firewall.pp 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/manifests/misc/firewall.pp b/manifests/misc/firewall.pp index af9213e..107d8bc 100644 --- a/manifests/misc/firewall.pp +++ b/manifests/misc/firewall.pp @@ -22,7 +22,7 @@ } -class firewall { +class firewall { # for each inbound ACL create an exported file on the main server # This is the definition called from all service manifests, e.g. @@ -30,9 +30,9 @@ define open_port( $port, - $hostname = $::hostname, - $ip_address= $::ipaddress, - $protocol = 'tcp', + $hostname = $::hostname, + $ip_address = $::ipaddress, + $protocol = 'tcp', ) { @@exported_acl_rule { $title: hostname => $hostname, -- To view, visit https://gerrit.wikimedia.org/r/169340 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e572e7aa5f60987f5e5329baf1c827aca45d3fd Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Matanya <mata...@foss.co.il> Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits