BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169573
Change subject: Fix visibility of dismiss button in ToC tutorial
......................................................................
Fix visibility of dismiss button in ToC tutorial
The @dimen/wrap_content hack doesn't work on all devices.
Using fixed value instead.
Ideally, the image should be exactly square.
In a later patch the image could be adjusted from
130x128 to 128x128.
Bug: 72595
Change-Id: I02e87782988205ab6e2f8d2ccd8bc0d54858503b
---
M wikipedia/res/values-h480dp/dimens.xml
M wikipedia/res/values/dimens.xml
2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/73/169573/1
diff --git a/wikipedia/res/values-h480dp/dimens.xml
b/wikipedia/res/values-h480dp/dimens.xml
index 901e9bc..02c73e5 100644
--- a/wikipedia/res/values-h480dp/dimens.xml
+++ b/wikipedia/res/values-h480dp/dimens.xml
@@ -3,7 +3,7 @@
<!--
ToC Intro
-->
- <dimen name="toc_intro_image_size">@dimen/wrap_content</dimen>
+ <dimen name="toc_intro_image_size">128dp</dimen>
<dimen name="toc_intro_image_marginTop">16dp</dimen>
<dimen name="toc_intro_image_marginBottom">48dp</dimen>
diff --git a/wikipedia/res/values/dimens.xml b/wikipedia/res/values/dimens.xml
index 72b807f..2828a86 100644
--- a/wikipedia/res/values/dimens.xml
+++ b/wikipedia/res/values/dimens.xml
@@ -1,9 +1,5 @@
<resources>
- <!-- trick to be able to use match_parent and wrap_content in dimen
resources -->
- <dimen name="match_parent">-1dp</dimen>
- <dimen name="wrap_content">-2dp</dimen>
-
<!-- Default screen margins, per the Android Design guidelines. -->
<dimen name="activity_horizontal_margin">16dp</dimen>
<dimen name="activity_vertical_margin">16dp</dimen>
--
To view, visit https://gerrit.wikimedia.org/r/169573
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02e87782988205ab6e2f8d2ccd8bc0d54858503b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
