Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169581
Change subject: Trigger tap events on phones where both touch and mouse are
supported
......................................................................
Trigger tap events on phones where both touch and mouse are supported
Bug: 72566
Change-Id: I24dcb20291e909ed4a12ee21f6844d801c916c81
---
M javascripts/externals/micro.tap.js
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/81/169581/1
diff --git a/javascripts/externals/micro.tap.js
b/javascripts/externals/micro.tap.js
index a3f05b7..8b9f3c5 100644
--- a/javascripts/externals/micro.tap.js
+++ b/javascripts/externals/micro.tap.js
@@ -33,9 +33,11 @@
moved = true;
}).
on('touchend', handleTap);
- } else {
- // FIXME: jQuery's on() doesn't allow useCapture argument (last argument,
true)
- window.addEventListener('mouseup', handleTap, true);
}
+
+ // Unconditionally register the mouseup as certain devices may support both
touch
+ // and mouse events e.g. BlackBerry Bold 9900
+ // FIXME: jQuery's on() doesn't allow useCapture argument (last argument,
true)
+ window.addEventListener('mouseup', handleTap, true);
}(jQuery));
--
To view, visit https://gerrit.wikimedia.org/r/169581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24dcb20291e909ed4a12ee21f6844d801c916c81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
