Dduvall has submitted this change and it was merged.
Change subject: Use alias_method when aliasing macro-defined attributes
......................................................................
Use alias_method when aliasing macro-defined attributes
Note this does not implement checks banning use of `alias` altogether.
Bug: 63307
Change-Id: I97191e9b6449d7220fde84e3367f939e6053fc4d
---
M lib/mediawiki_api/client.rb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dduvall: Looks good to me, approved
diff --git a/lib/mediawiki_api/client.rb b/lib/mediawiki_api/client.rb
index 2758cbc..44516db 100644
--- a/lib/mediawiki_api/client.rb
+++ b/lib/mediawiki_api/client.rb
@@ -11,7 +11,7 @@
attr_accessor :logged_in
- alias logged_in? logged_in
+ alias_method :logged_in?, :logged_in
def initialize(url, log = false)
@conn = Faraday.new(url: url) do |faraday|
--
To view, visit https://gerrit.wikimedia.org/r/168279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97191e9b6449d7220fde84e3367f939e6053fc4d
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/ruby/api
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
