Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169627

Change subject: hhvm: make HHVM's working directory be /var/tmp/hhvm
......................................................................

hhvm: make HHVM's working directory be /var/tmp/hhvm

jemalloc heap dumps go to the process's working directory by default.
Presumably there are other code-paths in HHVM that default to writing data to
the current working directory. It's important, therefore, that HHVM's working
directory not be in the /run ramdisk, because that can easily fill up.

Change-Id: I002b838e9c7afc1274b6382a30c556cd8dd6c80f
---
M modules/hhvm/files/hhvm.conf
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/27/169627/1

diff --git a/modules/hhvm/files/hhvm.conf b/modules/hhvm/files/hhvm.conf
index fc19065..523fd6f 100644
--- a/modules/hhvm/files/hhvm.conf
+++ b/modules/hhvm/files/hhvm.conf
@@ -11,7 +11,8 @@
   mkdir -p -m0755 "${HHVM_RUN_DIR:=/run/hhvm}"
   mkdir -p -m0750 "${HHVM_RUN_DIR}/cache"
   mkdir -p -m0775 "${HHVM_LOG_DIR:=/var/log/hhvm}"
-  chown -R "${HHVM_USER:=www-data}:${HHVM_GROUP:=www-data}" "$HHVM_RUN_DIR"
+  mkdir -p -m0775 "${HHVM_TMP_DIR:=/var/tmp/hhvm}"
+  chown -R "${HHVM_USER:=www-data}:${HHVM_GROUP:=www-data}" "$HHVM_RUN_DIR" 
"$HHVM_TMP_DIR"
   chown -R "syslog:${HHVM_GROUP}" "$HHVM_LOG_DIR"
 
   # Update the symlink `/usr/lib/x86_64-linux-gnu/hhvm/extensions/current`
@@ -36,7 +37,7 @@
   exec /sbin/start-stop-daemon --quiet --start \
     --chuid "${HHVM_USER:-www-data}:${HHVM_GROUP:-www-data}" \
     --make-pidfile --pidfile "${HHVM_RUN_DIR:-/run/hhvm}/hhvm.pid" \
-    --chdir "${HHVM_RUN_DIR:-/run/hhvm}" \
+    --chdir "${HHVM_TMP_DIR:-/var/tmp/hhvm}" \
     --startas /usr/bin/hhvm -- \
       --config "${HHVM_CONFIG_DIR:-/etc/hhvm}/fcgi.ini" \
       --mode server

-- 
To view, visit https://gerrit.wikimedia.org/r/169627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I002b838e9c7afc1274b6382a30c556cd8dd6c80f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to