Robert Vogel has submitted this change and it was merged.
Change subject: Added missing I18N
......................................................................
Added missing I18N
And fixed one I18N key to meet conventions
Change-Id: I8fd7d35e656067775b1e82819c5bcb0333545341
---
M PermissionManager/PermissionManager.setup.php
M PermissionManager/i18n/de.json
M PermissionManager/i18n/en.json
M PermissionManager/i18n/qqq.json
M PermissionManager/resources/BS.PermissionManager/panel/Manager.js
5 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
Robert Vogel: Verified; Looks good to me, approved
Siebrand: Looks good to me, but someone else must approve
diff --git a/PermissionManager/PermissionManager.setup.php
b/PermissionManager/PermissionManager.setup.php
index 570a3a8..25ba256 100644
--- a/PermissionManager/PermissionManager.setup.php
+++ b/PermissionManager/PermissionManager.setup.php
@@ -41,7 +41,7 @@
'bs-permissionmanager-titletpled-new',
'bs-permissionmanager-titletpled-edit',
'bs-permissionmanager-titletpled-delete',
- 'bs-PermissionManager-unsaved-changes'
+ 'bs-permissionmanager-unsaved-changes'
),
'localBasePath' => $IP,
'remoteBasePath' => &$GLOBALS['wgScriptPath']
diff --git a/PermissionManager/i18n/de.json b/PermissionManager/i18n/de.json
index 74a4499..09c60c8 100644
--- a/PermissionManager/i18n/de.json
+++ b/PermissionManager/i18n/de.json
@@ -39,5 +39,6 @@
"bs-permissionmanager-titletpled-delete": "Vorlage löschen",
"bs-permissionmanager-pref-lockmode": "Lockmode aktivieren",
"bs-permissionmanager-pref-skipsysns": "Systemnamensräume bei
eingschaltetem Lockmode ignorieren",
- "bs-permissionmanager-pref-enablerealitycheck": "Rechteprüfung
aktivieren"
+ "bs-permissionmanager-pref-enablerealitycheck": "Rechteprüfung
aktivieren",
+ "bs-permissionmanager-unsaved-changes": "Es existieren ungespeicherte
Änderungen. Willst du die Seite wirklich verlassen? Die ungespeicherten
Änderungen gehen in diesem Fall verloren"
}
diff --git a/PermissionManager/i18n/en.json b/PermissionManager/i18n/en.json
index edae6c1..699cd3e 100644
--- a/PermissionManager/i18n/en.json
+++ b/PermissionManager/i18n/en.json
@@ -38,5 +38,6 @@
"bs-permissionmanager-titletpled-delete": "Delete template",
"bs-permissionmanager-pref-lockmode": "Activate lockmode",
"bs-permissionmanager-pref-skipsysns": "Skip system namespaces if
lockmode is active",
- "bs-permissionmanager-pref-enablerealitycheck": "Activate permission
check"
+ "bs-permissionmanager-pref-enablerealitycheck": "Activate permission
check",
+ "bs-permissionmanager-unsaved-changes": "There are unsaved changes. Do
you really want to leave the page now? The unsaved changes will be lost."
}
diff --git a/PermissionManager/i18n/qqq.json b/PermissionManager/i18n/qqq.json
index 55e4f2a..54661e1 100644
--- a/PermissionManager/i18n/qqq.json
+++ b/PermissionManager/i18n/qqq.json
@@ -40,5 +40,6 @@
"bs-permissionmanager-titletpled-delete": "Window title for delete
template",
"bs-permissionmanager-pref-lockmode": "Option in
[{{canonicalurl:Special:WikiAdmin|mode=Preferences}}
Special:WikiAdmin?mode=Preferences], checkbox label for activate lockmode",
"bs-permissionmanager-pref-skipsysns": "Option in
[{{canonicalurl:Special:WikiAdmin|mode=Preferences}}
Special:WikiAdmin?mode=Preferences], checkbox label for skip system namespaces
if lockmode is active",
- "bs-permissionmanager-pref-enablerealitycheck": "Option in
[{{canonicalurl:Special:WikiAdmin|mode=Preferences}}
Special:WikiAdmin?mode=Preferences], checkbox label for activate permission
check"
+ "bs-permissionmanager-pref-enablerealitycheck": "Option in
[{{canonicalurl:Special:WikiAdmin|mode=Preferences}}
Special:WikiAdmin?mode=Preferences], checkbox label for activate permission
check",
+ "bs-permissionmanager-unsaved-changes": "Hint about data loss when a
user leaves the page without saving her/his changes"
}
diff --git a/PermissionManager/resources/BS.PermissionManager/panel/Manager.js
b/PermissionManager/resources/BS.PermissionManager/panel/Manager.js
index d9859f4..5069eb0 100644
--- a/PermissionManager/resources/BS.PermissionManager/panel/Manager.js
+++ b/PermissionManager/resources/BS.PermissionManager/panel/Manager.js
@@ -15,13 +15,14 @@
$(window).bind( 'beforeunload', function() {
var dataManager =
Ext.create('BS.PermissionManager.data.Manager');
if(dataManager.isDirty()) {
+ var msg =
mw.message('bs-permissionmanager-unsaved-changes').plain();
if(/chrome/.test(navigator.userAgent.toLowerCase())) { //chrome compatibility
- return
mw.message('bs-PermissionManager-unsaved-changes').plain();
+ return msg;
}
if(window.event) {
- window.event.returnValue =
mw.message('bs-PermissionManager-unsaved-changes').plain();
+ window.event.returnValue = msg;
} else {
- return
mw.message('bs-PermissionManager-unsaved-changes').plain();
+ return msg;
}
}
});
--
To view, visit https://gerrit.wikimedia.org/r/169332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fd7d35e656067775b1e82819c5bcb0333545341
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_22
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pigpen <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Smuggli <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
