Dbrant has submitted this change and it was merged.
Change subject: Change ActionBar search text every time a "Did you mean" query
is run.
......................................................................
Change ActionBar search text every time a "Did you mean" query is run.
When the full text search API thinks you've made a typo, it returns a "Did you
mean" result, which is a suggestion for a new search. When you tap on that
result in the app, it runs a new full text search query with that term.
This patch makes it so that when such a "Did you mean" query is run, the text
in the search box is updated so that it matches the query that's run, so that
it's clearer to the user how the results match the query that was initiated.
Change-Id: Ib1195b9649e01c46425f1e86523559235c108902
---
M wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
M wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
2 files changed, 12 insertions(+), 2 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
diff --git
a/wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
b/wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
index bad1e87..ac3d088 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/FullSearchFragment.java
@@ -89,8 +89,10 @@
searchSuggestion.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
- if (searchSuggestion.getTag() != null) {
- startSearch((String) searchSuggestion.getTag(), true);
+ String suggestion = (String) searchSuggestion.getTag();
+ if (suggestion != null) {
+ searchFragment.setSearchText(suggestion);
+ startSearch(suggestion, true);
}
}
});
diff --git
a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
index 1fcf766..ce16dfa 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
@@ -188,6 +188,14 @@
}
/**
+ * Changes the search text box to contain a different string.
+ * @param text The text you want to make the search box display.
+ */
+ public void setSearchText(String text) {
+ searchView.setQuery(text, false);
+ }
+
+ /**
* Show a particular panel, which can be one of:
* - PANEL_RECENT_SEARCHES
* - PANEL_TITLE_SEARCH
--
To view, visit https://gerrit.wikimedia.org/r/169319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1195b9649e01c46425f1e86523559235c108902
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
