MarkAHershberger has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169734

Change subject: AuthorDate: 2014-10-20 23:40:20 +0200
......................................................................

AuthorDate: 2014-10-20 23:40:20 +0200

Add Content-Length header for job queue requests

Include the Content-Length header in job queue POST requests to meet the
requirement by certain servers, avoiding HTTP 411 responses.

Bug: 72274
Change-Id: Icf34bca58c792225d735d576213d6887015459ca
---
M RELEASE-NOTES-1.23
M includes/Wiki.php
2 files changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/34/169734/1

diff --git a/RELEASE-NOTES-1.23 b/RELEASE-NOTES-1.23
index f2c7abd..05570cb 100644
--- a/RELEASE-NOTES-1.23
+++ b/RELEASE-NOTES-1.23
@@ -1,6 +1,14 @@
 Security reminder: MediaWiki does not require PHP's register_globals. If you
 have it on, turn it '''off''' if you can.
 
+== MediaWiki 1.23.6 ==
+
+This is a maintenance release of the MediaWiki 1.23 branch.
+
+=== Changes since 1.23.5 ===
+* (Bug 72274) Job queue not running (HTTP 411) due to missing
+  Content-Length: header
+
 == MediaWiki 1.23.5 ==
 
 This is a security release of the MediaWiki 1.23 branch.
diff --git a/includes/Wiki.php b/includes/Wiki.php
index fbafba8..95beb20 100644
--- a/includes/Wiki.php
+++ b/includes/Wiki.php
@@ -680,7 +680,7 @@
                }
 
                $url = wfAppendQuery( wfScript( 'index' ), $query );
-               $req = "POST $url HTTP/1.1\r\nHost: 
{$info['host']}\r\nConnection: Close\r\n\r\n";
+               $req = "POST $url HTTP/1.1\r\nHost: 
{$info['host']}\r\nConnection: Close\r\nContent-Length: 0\r\n\r\n";
 
                wfDebugLog( 'runJobs', "Running $n job(s) via '$url'\n" );
                // Send a cron API request to be performed in the background.

-- 
To view, visit https://gerrit.wikimedia.org/r/169734
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf34bca58c792225d735d576213d6887015459ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_23
Gerrit-Owner: MarkAHershberger <[email protected]>
Gerrit-Reviewer: Poke <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to