Hashar has submitted this change and it was merged. Change subject: Warn when creating TextContent around false/null. ......................................................................
Warn when creating TextContent around false/null. Instantiating a TextContent instance around a null or false value instead of a string may indicate an error and should thus trigger a warning and thereby make tests fail. Change-Id: I0864bbf31040d0c5db96a90ff427dc9dd3ccbd67 --- M includes/content/TextContent.php 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Aude: Looks good to me, but someone else must approve Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/30140 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0864bbf31040d0c5db96a90ff427dc9dd3ccbd67 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
