Bmansurov has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169927
Change subject: Close search overlay when clicking on the overlay background
......................................................................
Close search overlay when clicking on the overlay background
Bug: 72656
Change-Id: If5f940f9a9bacc2404353b37ce07c7a6812dffce
---
M javascripts/modules/search/SearchOverlay.js
M less/modules/search/SearchOverlay.less
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/27/169927/1
diff --git a/javascripts/modules/search/SearchOverlay.js
b/javascripts/modules/search/SearchOverlay.js
index 16f7e20..0d6afd9 100644
--- a/javascripts/modules/search/SearchOverlay.js
+++ b/javascripts/modules/search/SearchOverlay.js
@@ -93,7 +93,7 @@
// tapping on background only should hide the overlay
this.$overlayContent
.on( 'tap', function () {
- window.history.back();
+ self.$( '.cancel' ).trigger( 'tap' );
} )
.find( '> div' ).on( 'tap', function ( ev ) {
ev.stopPropagation();
diff --git a/less/modules/search/SearchOverlay.less
b/less/modules/search/SearchOverlay.less
index 0debb28..f6fd4e0 100644
--- a/less/modules/search/SearchOverlay.less
+++ b/less/modules/search/SearchOverlay.less
@@ -15,6 +15,12 @@
padding: 0;
}
+ .overlay-content {
+ // used to close the overlay in firefox
+ height: 100%;
+ width: 100%;
+ }
+
.search-content {
border-bottom: 1px solid @grayLight;
cursor: pointer;
--
To view, visit https://gerrit.wikimedia.org/r/169927
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5f940f9a9bacc2404353b37ce07c7a6812dffce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
