jenkins-bot has submitted this change and it was merged.
Change subject: Don't create tables with a thead
......................................................................
Don't create tables with a thead
There is no way for the user to see the difference between
thead and tbody, no way for them to manipulate this difference
(whether a cell is header/data is on a cell level), and
Parsoid doesn't understand <thead>s. Eventually we should
deal with this correctly, but right now that isn't feasible.
Change-Id: I7a45d42f761ab982f59a939b6368c5e59e4dea7a
---
M src/ui/actions/ve.ui.TableAction.js
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/actions/ve.ui.TableAction.js
b/src/ui/actions/ve.ui.TableAction.js
index 61f1c7f..8d0bb7e 100644
--- a/src/ui/actions/ve.ui.TableAction.js
+++ b/src/ui/actions/ve.ui.TableAction.js
@@ -66,12 +66,10 @@
}
data.push( tableElement );
- if ( options.header ) {
- data.push( { type: 'tableSection', attributes: { style:
'header' } } );
- data = data.concat( ve.dm.TableRowNode.static.createData( {
style: 'header', cellCount: numberOfCols } ) );
- data.push( { type: '/tableSection' } );
- }
data.push( { type: 'tableSection', attributes: { style: 'body' } } );
+ if ( options.header ) {
+ data = data.concat( ve.dm.TableRowNode.static.createData( {
style: 'header', cellCount: numberOfCols } ) );
+ }
for ( i = 0; i < numberOfRows; i++ ) {
data = data.concat( ve.dm.TableRowNode.static.createData( {
style: 'data', cellCount: numberOfCols } ) );
}
--
To view, visit https://gerrit.wikimedia.org/r/169784
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a45d42f761ab982f59a939b6368c5e59e4dea7a
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
