Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/169937
Change subject: Don't create pipes for `P.spawn` by default.
......................................................................
Don't create pipes for `P.spawn` by default.
Pipes will block if they get enough input, and our users are not
listening to the pipe (we're not even exposing it to the caller).
Change-Id: I0e6247bfbee1b1eb67441f21d39c107e4806bc01
---
M lib/p.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection/OfflineContentGenerator/latex_renderer
refs/changes/37/169937/1
diff --git a/lib/p.js b/lib/p.js
index f245e27..1a997ea 100644
--- a/lib/p.js
+++ b/lib/p.js
@@ -18,7 +18,7 @@
// Returns a promise for completion after spawning `program`
P.spawn = function(program, args, options) {
return new Promise(function(resolve, reject) {
- spawn(program, args || [], options || {}).
+ spawn(program, args || [], options || { stdio: 'inherit' }).
on('exit', function(exitCode) {
if (exitCode === 0) {
resolve();
--
To view, visit https://gerrit.wikimedia.org/r/169937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e6247bfbee1b1eb67441f21d39c107e4806bc01
Gerrit-PatchSet: 1
Gerrit-Project:
mediawiki/extensions/Collection/OfflineContentGenerator/latex_renderer
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
