Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169992

Change subject: puppetmaster: restart apache2 once on logrotate
......................................................................

puppetmaster: restart apache2 once on logrotate

logrotate right now as missing the "sharedscripts" option, which meant
that Apache was gracefully restarted once per each logfile (i.e. 7 times
on palladium) in succession, very quickly. This may have had something
to do with mod_passenger/puppetmaster failures that were logged at the
time and is nevertheless an important omission. (while at it, also add
delaycompress)

Change-Id: I10fd2fc699c3a3ca15188a3c88563fccca0b4a53
---
M modules/puppetmaster/files/logrotate-passenger
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/92/169992/1

diff --git a/modules/puppetmaster/files/logrotate-passenger 
b/modules/puppetmaster/files/logrotate-passenger
index fffecca..57f2daa 100644
--- a/modules/puppetmaster/files/logrotate-passenger
+++ b/modules/puppetmaster/files/logrotate-passenger
@@ -5,10 +5,12 @@
 
 # Rotate puppetmaster passenger (apache) logs
 /var/log/apache2/*.log {
+       daily
        missingok
        rotate 7
-       daily
        compress
+       delaycompress
+       sharedscripts
        postrotate
                /usr/sbin/service apache2 graceful
        endscript

-- 
To view, visit https://gerrit.wikimedia.org/r/169992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I10fd2fc699c3a3ca15188a3c88563fccca0b4a53
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to