Alexandros Kosiaris has submitted this change and it was merged.
Change subject: Add a description parameter to ganglia::view
......................................................................
Add a description parameter to ganglia::view
undef by default for backwards compatibility, when specified it
overrides the $view_name variable allowing for prettier names on ganglia
views
Change-Id: I86cc345a295d2e9a5b76fc4e5a9b4c77ee7de3f8
---
M manifests/ganglia.pp
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Alexandros Kosiaris: Looks good to me, approved
jenkins-bot: Verified
diff --git a/manifests/ganglia.pp b/manifests/ganglia.pp
index ee590be..b524857 100644
--- a/manifests/ganglia.pp
+++ b/manifests/ganglia.pp
@@ -700,13 +700,18 @@
$default_size = 'large',
$conf_dir = "${ganglia::web::ganglia_confdir}/conf",
$template = 'ganglia/ganglia_view.json.erb',
+ $description = undef,
$ensure = 'present'
)
{
require ganglia::web
# require ganglia::web
- $view_name = $name
+ if $description {
+ $view_name = $name
+ } else {
+ $view_name = $description
+ }
file { "${conf_dir}/view_${name}.json":
ensure => $ensure,
content => template($template),
--
To view, visit https://gerrit.wikimedia.org/r/170003
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86cc345a295d2e9a5b76fc4e5a9b4c77ee7de3f8
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits