jenkins-bot has submitted this change and it was merged.
Change subject: Always use "edit" as aliases edit toolbar button label
......................................................................
Always use "edit" as aliases edit toolbar button label
Consistent with JavaScript behaviour; Fixes error that button was not
properly initialized in JS when there are no aliases.
Change-Id: I933cefecc23bf9045d3ecbc98c04daee2af21e68
---
M repo/includes/View/FingerprintView.php
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, approved
Jeroen De Dauw: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/repo/includes/View/FingerprintView.php
b/repo/includes/View/FingerprintView.php
index 18c7f4a..2563090 100644
--- a/repo/includes/View/FingerprintView.php
+++ b/repo/includes/View/FingerprintView.php
@@ -138,8 +138,7 @@
*/
private function getHtmlForAliases( AliasGroupList $aliasGroups,
EntityId $entityId = null, $editable ) {
$hasAliases = $aliasGroups->hasGroupForLanguage(
$this->languageCode );
- $action = $hasAliases ? 'edit' : 'add';
- $editSection = $this->getHtmlForEditSection( 'SetAliases',
$entityId, $editable, $action );
+ $editSection = $this->getHtmlForEditSection( 'SetAliases',
$entityId, $editable, 'edit' );
if ( $hasAliases ) {
$aliasesHtml = '';
--
To view, visit https://gerrit.wikimedia.org/r/169712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I933cefecc23bf9045d3ecbc98c04daee2af21e68
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf6
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
