jenkins-bot has submitted this change and it was merged.
Change subject: API: Add doc warning to ApiPageSet::populateFromQueryResult
......................................................................
API: Add doc warning to ApiPageSet::populateFromQueryResult
The cause of bug 72764 was an extension misusing
ApiPageSet::populateFromQueryResult(). Add a warning in the docs for
that method about proper usage.
Bug: 72764
Change-Id: I5b0a069d796f7f41ab0b16048d7b3d6600207383
---
M includes/api/ApiPageSet.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/api/ApiPageSet.php b/includes/api/ApiPageSet.php
index ab705b2..db5eb52 100644
--- a/includes/api/ApiPageSet.php
+++ b/includes/api/ApiPageSet.php
@@ -669,6 +669,10 @@
/**
* Populate this PageSet from a rowset returned from the database
+ *
+ * Note that the query result must include the columns returned by
+ * $this->getPageTableFields().
+ *
* @param DatabaseBase $db
* @param ResultWrapper $queryResult Query result object
*/
--
To view, visit https://gerrit.wikimedia.org/r/170094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b0a069d796f7f41ab0b16048d7b3d6600207383
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
