jenkins-bot has submitted this change and it was merged.
Change subject: Clean up entityChangers tests
......................................................................
Clean up entityChangers tests
Main reason for this patch are the somewhat confusing strings in
the tests that look like class names.
Change-Id: I9251b4bf6a85133fcb264ad3528002d958e15d2c
---
M lib/resources/entityChangers/ClaimsChanger.js
M lib/resources/entityChangers/DescriptionsChanger.js
M lib/resources/entityChangers/LabelsChanger.js
M lib/resources/entityChangers/ReferencesChanger.js
M lib/resources/entityChangers/SiteLinksChanger.js
M lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
M lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
M lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
M lib/resources/parsers/getStore.js
M lib/resources/wikibase.RepoApi/wikibase.RepoApiError.js
M lib/resources/wikibase.store/store.ApiEntityStore.js
M lib/resources/wikibase.store/store.CombiningEntityStore.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
M lib/tests/qunit/wikibase.RepoApi/wikibase.RepoApiError.tests.js
27 files changed, 81 insertions(+), 94 deletions(-)
Approvals:
Henning Snater: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/entityChangers/ClaimsChanger.js
b/lib/resources/entityChangers/ClaimsChanger.js
index 3f26a36..66c7139 100644
--- a/lib/resources/entityChangers/ClaimsChanger.js
+++ b/lib/resources/entityChangers/ClaimsChanger.js
@@ -45,9 +45,9 @@
* - {wikibase.RepoApiError}
*/
removeClaim: function( claim ) {
- var deferred = $.Deferred();
- var self = this;
- var guid = claim.getGuid();
+ var deferred = $.Deferred(),
+ self = this,
+ guid = claim.getGuid();
this._api.removeClaim( guid,
this._revisionStore.getClaimRevision( guid ) )
.done( function( response ) {
@@ -73,8 +73,8 @@
* - {wikibase.RepoApiError}
*/
setClaim: function( claim, index ) {
- var self = this;
- var deferred = $.Deferred();
+ var self = this,
+ deferred = $.Deferred();
this._api.setClaim(
claim.toJSON(),
@@ -82,8 +82,8 @@
index
)
.done( function( result ) {
- var savedClaim = wb.datamodel.Claim.newFromJSON(
result.claim );
- var pageInfo = result.pageinfo;
+ var savedClaim = wb.datamodel.Claim.newFromJSON(
result.claim ),
+ pageInfo = result.pageinfo;
// Update revision store:
self._revisionStore.setClaimRevision(
pageInfo.lastrevid, savedClaim.getGuid() );
diff --git a/lib/resources/entityChangers/DescriptionsChanger.js
b/lib/resources/entityChangers/DescriptionsChanger.js
index e39118b..3ff5885 100644
--- a/lib/resources/entityChangers/DescriptionsChanger.js
+++ b/lib/resources/entityChangers/DescriptionsChanger.js
@@ -43,8 +43,8 @@
* - {wikibase.RepoApiError}
*/
setDescription: function( description, language ) {
- var self = this;
- var deferred = $.Deferred();
+ var self = this,
+ deferred = $.Deferred();
this._api.setDescription(
this._entity.getId(),
diff --git a/lib/resources/entityChangers/LabelsChanger.js
b/lib/resources/entityChangers/LabelsChanger.js
index f044897..311c64e 100644
--- a/lib/resources/entityChangers/LabelsChanger.js
+++ b/lib/resources/entityChangers/LabelsChanger.js
@@ -43,8 +43,8 @@
* - {wikibase.RepoApiError}
*/
setLabel: function( label, language ) {
- var self = this;
- var deferred = $.Deferred();
+ var self = this,
+ deferred = $.Deferred();
this._api.setLabel(
this._entity.getId(),
diff --git a/lib/resources/entityChangers/ReferencesChanger.js
b/lib/resources/entityChangers/ReferencesChanger.js
index ac16be9..087b45b 100644
--- a/lib/resources/entityChangers/ReferencesChanger.js
+++ b/lib/resources/entityChangers/ReferencesChanger.js
@@ -46,8 +46,8 @@
* - {wikibase.RepoApiError}
*/
removeReference: function( statementGuid, reference ) {
- var deferred = $.Deferred();
- var self = this;
+ var deferred = $.Deferred(),
+ self = this;
this._api.removeReferences(
statementGuid,
@@ -78,8 +78,9 @@
* - {wikibase.RepoApiError}
*/
setReference: function( statementGuid, reference, index ) {
- var deferred = $.Deferred();
- var self = this;
+ var deferred = $.Deferred(),
+ self = this;
+
this._api.setReference(
statementGuid,
reference.getSnaks().toJSON(),
@@ -88,8 +89,8 @@
index
)
.done( function( result ) {
- var savedReference =
wb.datamodel.Reference.newFromJSON( result.reference );
- var pageInfo = result.pageinfo;
+ var savedReference =
wb.datamodel.Reference.newFromJSON( result.reference ),
+ pageInfo = result.pageinfo;
// Update revision store:
self._revisionStore.setClaimRevision(
pageInfo.lastrevid, statementGuid );
diff --git a/lib/resources/entityChangers/SiteLinksChanger.js
b/lib/resources/entityChangers/SiteLinksChanger.js
index 00363cc..23e18b3 100644
--- a/lib/resources/entityChangers/SiteLinksChanger.js
+++ b/lib/resources/entityChangers/SiteLinksChanger.js
@@ -43,8 +43,8 @@
* - {wikibase.RepoApiError}
*/
setSiteLink: function( siteLink, language ) {
- var self = this;
- var deferred = $.Deferred();
+ var self = this,
+ deferred = $.Deferred();
this._api.setSitelink(
this._entity.getId(),
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
index becc2ea..8650b87 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
@@ -202,9 +202,8 @@
var self = this;
return function( term ) {
- var deferred = $.Deferred();
-
- var data = self._getData( term );
+ var deferred = $.Deferred(),
+ data = self._getData( term );
if( self.options.limit ) {
$.extend( data, {
@@ -361,9 +360,8 @@
* @see jQuery.ui.suggester._getSuggestionsFromArray
*/
_getSuggestionsFromArray: function( term, source ) {
- var deferred = $.Deferred();
-
- var matcher = new RegExp( this._escapeRegex( term ),
'i' );
+ var deferred = $.Deferred(),
+ matcher = new RegExp( this._escapeRegex( term
), 'i' );
deferred.resolve( $.grep( source, function( item ) {
if( item.aliases ) {
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index 7d627b2..0ff13b9 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -568,8 +568,8 @@
// Disable "move up" button of topmost and "move down"
button of bottommost
// referenceview:
- var $topMostReferenceview =
referencesListview.items().first();
- var $bottomMostReferenceview =
referencesListview.items().last();
+ var $topMostReferenceview =
referencesListview.items().first(),
+ $bottomMostReferenceview =
referencesListview.items().last();
if ( $topMostReferenceview.get( 0 ) ===
$referenceview.get( 0 ) ) {
$referenceview.data( 'movetoolbar' ).getButton(
'up' ).disable();
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
b/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
index 7d3d96f..b51474e 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
@@ -283,9 +283,8 @@
* @TODO: Error tooltip should be a separate tooltip derivative.
*/
_buildErrorTooltip: function() {
- var $message = $( '<div/>' ).addClass( 'wb-error ' +
this.widgetFullName + '-error' );
-
- var $mainMessage = $( '<div/>' ).text(
this.options.content.message ).appendTo( $message );
+ var $message = $( '<div/>' ).addClass( 'wb-error ' +
this.widgetFullName + '-error' ),
+ $mainMessage = $( '<div/>' ).text(
this.options.content.message ).appendTo( $message );
// Append detailed error message if given; hide it behind
toggle:
if( this.options.content.detailedMessage ) {
diff --git
a/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
b/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
index 7b593c9..631e3d4 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
@@ -219,9 +219,9 @@
* Attaches event handlers to the value view widget's element.
*/
_attachEventHandlers: function() {
- var self = this;
- var $viewPort = this.$viewPort;
- var heightAnimationQueue = self.variationBaseClass +
'height';
+ var self = this,
+ $viewPort = this.$viewPort,
+ heightAnimationQueue = self.variationBaseClass
+ 'height';
this._removeEventHandlers();
@@ -234,9 +234,9 @@
} )
.on( 'inputextenderanimation.' +
this.variationBaseClass, function( animationEvent ) {
animationEvent.animationCallbacks.add( 'done',
function() {
- var $input = $( animationEvent.target );
- var $extension = $input.data(
'inputextender' ).extension();
- var newHeight = 0;
+ var $input = $( animationEvent.target ),
+ $extension = $input.data(
'inputextender' ).extension(),
+ newHeight = 0;
$viewPort.stop( heightAnimationQueue,
true );
@@ -262,9 +262,9 @@
} );
} )
.on( 'inputextendercontentanimation.' +
this.variationBaseClass, function( animationEvent ) {
- var $input = $( animationEvent.target );
- var inputHeight = $input.outerHeight();
- var $extension = $input.data( 'inputextender'
).extension();
+ var $input = $( animationEvent.target ),
+ inputHeight = $input.outerHeight(),
+ $extension = $input.data(
'inputextender' ).extension();
animationEvent.animationCallbacks
.add( 'progress', function() {
diff --git a/lib/resources/parsers/getStore.js
b/lib/resources/parsers/getStore.js
index fa78791..157eac5 100644
--- a/lib/resources/parsers/getStore.js
+++ b/lib/resources/parsers/getStore.js
@@ -14,11 +14,9 @@
* @return {valueParsers.ValueParserStore}
*/
wb.parsers.getStore = function( api ) {
- var apiCaller = new wb.api.ParseValueCaller( api );
-
- var ApiBasedValueParser = wb.parsers.getApiBasedValueParserConstructor(
apiCaller );
-
- var parserStore = new vp.ValueParserStore( vp.NullParser );
+ var apiCaller = new wb.api.ParseValueCaller( api ),
+ ApiBasedValueParser =
wb.parsers.getApiBasedValueParserConstructor( apiCaller ),
+ parserStore = new vp.ValueParserStore( vp.NullParser );
parserStore.registerDataValueParser(
vp.StringParser,
diff --git a/lib/resources/wikibase.RepoApi/wikibase.RepoApiError.js
b/lib/resources/wikibase.RepoApi/wikibase.RepoApiError.js
index f440ff7..487f1b1 100644
--- a/lib/resources/wikibase.RepoApi/wikibase.RepoApiError.js
+++ b/lib/resources/wikibase.RepoApi/wikibase.RepoApiError.js
@@ -88,11 +88,11 @@
* @param {Object} details Object returned from the API containing
detailed information
* @param {string} [apiAction] API action (e.g. 'save', 'remove') that
may be passed to
* determine a specific message
- * @return {wb.RepoApiError}
+ * @return {wikibase.RepoApiError}
*/
wb.RepoApiError.newFromApiResponse = function( details, apiAction ) {
- var detailedMessage = '';
- var errorCode = '';
+ var errorCode = '',
+ detailedMessage = '';
if ( details.error ) {
errorCode = details.error.code;
diff --git a/lib/resources/wikibase.store/store.ApiEntityStore.js
b/lib/resources/wikibase.store/store.ApiEntityStore.js
index c54add7..f8ea4de 100644
--- a/lib/resources/wikibase.store/store.ApiEntityStore.js
+++ b/lib/resources/wikibase.store/store.ApiEntityStore.js
@@ -53,10 +53,10 @@
* @see wikibase.store.EntityStore.getMultipleRaw
*/
getMultipleRaw: function( entityIds ) {
- var deferreds = $.map( entityIds, function() { return
$.Deferred(); } );
- var self = this;
- var entityIdsToFetch = [];
- var entityIdToIndex = {};
+ var deferreds = $.map( entityIds, function() { return
$.Deferred(); } ),
+ self = this,
+ entityIdsToFetch = [],
+ entityIdToIndex = {};
$.each( entityIds, function( i, entityId ) {
if( self._entities.hasOwnProperty( entityId ) )
{
diff --git a/lib/resources/wikibase.store/store.CombiningEntityStore.js
b/lib/resources/wikibase.store/store.CombiningEntityStore.js
index ad205eb..57002d3 100644
--- a/lib/resources/wikibase.store/store.CombiningEntityStore.js
+++ b/lib/resources/wikibase.store/store.CombiningEntityStore.js
@@ -13,8 +13,9 @@
* resolves itself.
*/
function whenFinished( arr ) {
- var deferred = $.Deferred();
- var returnsExpected = arr.length;
+ var deferred = $.Deferred(),
+ returnsExpected = arr.length;
+
$.each( arr, function( i, promise ) {
promise.always( function() {
if( --returnsExpected <= 0 ) {
@@ -22,6 +23,7 @@
}
} );
} );
+
return deferred.promise();
}
@@ -29,9 +31,9 @@
* An asynchronous reduce which fails when the first handler fails
*/
function asyncReduce( arr, callback, initialValue ) {
- var deferred = $.Deferred();
- var index = 0;
- var previousValue = initialValue;
+ var deferred = $.Deferred(),
+ index = 0,
+ previousValue = initialValue;
function tryNext() {
if( arr.length <= index ) {
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
index 8a6fe23..b76be71 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.aliasesview.tests.js
@@ -12,8 +12,8 @@
*/
var createAliasesview = function( options ) {
options = $.extend( {
- entityId: 'i am an entity id',
- aliasesChanger: 'i am an aliasesChanger',
+ entityId: 'i am an EntityId',
+ aliasesChanger: 'i am an AliasesChanger',
value: {
language: 'en',
aliases: ['a', 'b', 'c']
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
index 15f37a6..9124ac8 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
@@ -30,7 +30,7 @@
value: value || null,
entityStore: entityStore,
valueViewBuilder: valueViewBuilder,
- entityChangersFactory: 'entityChangersFactory'
+ entityChangersFactory: 'i am an EntityChangersFactory'
};
return $( '<div/>' )
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
index abaf23b..3fd14cf 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.descriptionview.tests.js
@@ -2,7 +2,6 @@
* @licence GNU GPL v2+
* @author H. Snater < [email protected] >
*/
-
( function( $, QUnit ) {
'use strict';
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
index 41b0a59..a8227da 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.entityview.tests.js
@@ -13,19 +13,13 @@
*/
var createEntityview = function( options, $node ) {
options = $.extend( {
- entityStore: 'i am an entity store',
+ entityStore: 'i am an EntityStore',
entityChangersFactory: {
- getAliasesChanger: function() {
- return 'i am an alias changer';
- },
- getDescriptionsChanger: function() {
- return 'i am a descriptions changer';
- },
- getLabelsChanger: function() {
- return 'i am a labels changer';
- }
+ getAliasesChanger: function() { return 'i am an
AliasesChanger'; },
+ getDescriptionsChanger: function() { return 'i am a
DescriptionsChanger'; },
+ getLabelsChanger: function() { return 'i am a
LabelsChanger'; }
},
- api: 'i am an api',
+ api: 'i am an Api',
valueViewBuilder: 'i am a valueview builder',
value: new wb.datamodel.Item( {
id: 'Q1',
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
index f4de6c0..3cb95da 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
@@ -22,11 +22,11 @@
description: 'en-description'
}
],
- entityId: 'i am an entity id',
+ entityId: 'i am an EntityId',
entityChangersFactory: {
- getAliasesChanger: function () { return
'aliasesChanger'; },
- getDescriptionsChanger: function () { return
'descriptionsChanger'; },
- getLabelsChanger: function () { return 'labelsChanger';
}
+ getAliasesChanger: function() { return 'i am an
AliasesChanger'; },
+ getDescriptionsChanger: function() { return 'i am a
DescriptionsChanger'; },
+ getLabelsChanger: function() { return 'i am a
LabelsChanger'; }
}
}, options || {} );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
index 1f78f56..4d3da45 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
@@ -11,11 +11,11 @@
*/
var createFingerprintlistview = function( options ) {
options = $.extend( {
- entityId: 'i am an entity id',
+ entityId: 'i am an EntityId',
entityChangersFactory: {
- getAliasesChanger: function () { return
'aliasesChanger'; },
- getDescriptionsChanger: function () { return
'descriptionsChanger'; },
- getLabelsChanger: function () { return 'labelsChanger';
}
+ getAliasesChanger: function() { return 'i am an
AliasesChanger'; },
+ getDescriptionsChanger: function() { return 'i am a
DescriptionsChanger'; },
+ getLabelsChanger: function() { return 'i am a
LabelsChanger'; }
},
value: [
{
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
index 8be0604..fc98353 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
@@ -13,15 +13,15 @@
*/
var createFingerprintview = function( options, $node ) {
options = $.extend( {
- entityId: 'i am an entity id',
+ entityId: 'i am an EntityId',
entityChangersFactory: {
- getAliasesChanger: function() { return
'aliasesChanger'; },
+ getAliasesChanger: function() { return 'i am an
AliasesChanger'; },
getDescriptionsChanger: function() {
return {
setDescription: function() { return
$.Deferred().resolve(); }
};
},
- getLabelsChanger: function () {
+ getLabelsChanger: function() {
return {
setLabel: function() { return
$.Deferred().resolve(); }
};
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
index a0638a0..c153a7b 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.labelview.tests.js
@@ -13,8 +13,8 @@
*/
var createLabelview = function( options, $node ) {
options = $.extend( {
- labelsChanger: 'labelsChanger',
- entityId: 'i am an entity id',
+ entityId: 'i am an EntityId',
+ labelsChanger: 'i am a LabelsChanger',
value: {
language: 'en',
label: 'test label'
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
index 64edc66..d6ce29f 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.referenceview.tests.js
@@ -38,7 +38,7 @@
statementGuid: statementGuid,
entityStore: entityStore,
valueViewBuilder: valueViewBuilder,
- referencesChanger: 'referencesChanger'
+ referencesChanger: 'i am a ReferencesChanger'
} );
return $( '<div/>' )
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
index 1e1d071..073a041 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgrouplistview.tests.js
@@ -2,7 +2,6 @@
* @licence GNU GPL v2+
* @author H. Snater < [email protected] >
*/
-
( function( $, wb, QUnit ) {
'use strict';
@@ -12,8 +11,8 @@
*/
function createSitelinkgrouplistview( options ) {
options = $.extend( {
- siteLinksChanger: 'siteLinksChanger',
- entityStore: 'i am an entity store'
+ siteLinksChanger: 'i am a SiteLinksChanger',
+ entityStore: 'i am an EntityStore'
}, options );
return $( '<div/>' )
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
index 7a7c4ef..baa03e6 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkgroupview.tests.js
@@ -2,7 +2,6 @@
* @licence GNU GPL v2+
* @author H. Snater < [email protected] >
*/
-
( function( $, wb, QUnit ) {
'use strict';
@@ -12,7 +11,7 @@
*/
function createSitelinkgroupview( options ) {
options = $.extend( {
- siteLinksChanger: 'siteLinksChanger',
+ siteLinksChanger: 'i am a SiteLinksChanger',
entityStore: new wb.store.EntityStore()
}, options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
index cead5f7..427a575 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
@@ -2,7 +2,6 @@
* @licence GNU GPL v2+
* @author H. Snater < [email protected] >
*/
-
( function( $, wb, QUnit ) {
'use strict';
@@ -12,7 +11,7 @@
*/
function createSitelinklistview( options ) {
options = $.extend( {
- siteLinksChanger: 'siteLinksChanger',
+ siteLinksChanger: 'i am a SiteLinksChanger',
entityStore: new wb.store.EntityStore(),
allowedSiteIds: ['aawiki', 'enwiki']
}, options );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
index a1af7cc..d9f9126 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinkview.tests.js
@@ -2,7 +2,6 @@
* @licence GNU GPL v2+
* @author H. Snater < [email protected] >
*/
-
( function( $, wb, QUnit ) {
'use strict';
diff --git a/lib/tests/qunit/wikibase.RepoApi/wikibase.RepoApiError.tests.js
b/lib/tests/qunit/wikibase.RepoApi/wikibase.RepoApiError.tests.js
index a61f900..a386f81 100644
--- a/lib/tests/qunit/wikibase.RepoApi/wikibase.RepoApiError.tests.js
+++ b/lib/tests/qunit/wikibase.RepoApi/wikibase.RepoApiError.tests.js
@@ -50,7 +50,7 @@
QUnit.test( 'Validate errors created via factory method', function(
assert ) {
var error = wb.RepoApiError.newFromApiResponse( {
- error: { info: 'detailed message', code:
'error-code' }
+ error: { code: 'error-code', info: 'detailed
message' }
} );
assert.equal(
--
To view, visit https://gerrit.wikimedia.org/r/168271
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9251b4bf6a85133fcb264ad3528002d958e15d2c
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
