jenkins-bot has submitted this change and it was merged.
Change subject: Deprecate `one` function
......................................................................
Deprecate `one` function
Change-Id: Id30b021e273c3cf82e49443504056375ea182c27
---
M javascripts/common/eventemitter.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/common/eventemitter.js
b/javascripts/common/eventemitter.js
index b7eebec..04c7774 100644
--- a/javascripts/common/eventemitter.js
+++ b/javascripts/common/eventemitter.js
@@ -16,6 +16,9 @@
one: OO.EventEmitter.prototype.once
}, OO.EventEmitter.prototype ) );
+ mw.log.deprecate( EventEmitter.prototype, 'one',
+ EventEmitter.prototype.once, 'Be a cool kid and use "once"
instead.' );
+
M.define( 'eventemitter', EventEmitter );
// FIXME: if we want more of M's functionality in loaded in <head>,
// move this to a separate file
--
To view, visit https://gerrit.wikimedia.org/r/168724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id30b021e273c3cf82e49443504056375ea182c27
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Mantle
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
