jenkins-bot has submitted this change and it was merged.
Change subject: Add query parameter to force WikiGrok version
......................................................................
Add query parameter to force WikiGrok version
For example, adding wikigrokversion=a to the query string forces
WikiGrok version A.
Change-Id: Iab2cf5640765d7dfefa06b48f1af2bc2d64b63d0
---
M javascripts/modules/wikigrok/wikigrok.js
1 file changed, 19 insertions(+), 2 deletions(-)
Approvals:
Jhernandez: Looks good to me, but someone else must approve
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/wikigrok/wikigrok.js
b/javascripts/modules/wikigrok/wikigrok.js
index f3f3be1..423d65c 100644
--- a/javascripts/modules/wikigrok/wikigrok.js
+++ b/javascripts/modules/wikigrok/wikigrok.js
@@ -13,7 +13,8 @@
view: 'modules/wikigrok/WikiGrokDialogB'
}
},
- version;
+ version,
+ DEFAULT_VERSION = 'A';
/*
* Gets the version of wikigrok to use.
@@ -24,11 +25,27 @@
* If anonymous:
* * If it had any particular version assigned, use that one.
* * Else, assign randomly a wikigrok version to use.
+ *
+ * The `wikigrokversion` query parameter can be used to override this
logic,
+ * `wikigrokversion=a` means that A will always be used. If the override
+ * version doesn't exist, then the default version (currently A) will
be used.
+ *
* @return {Object}
*/
function getWikiGrokVersion() {
var cookieName = mw.config.get( 'wgCookiePrefix' ) +
'-wikiGrokAnonymousVersion',
- anonVersion = $.cookie( cookieName );
+ anonVersion = $.cookie( cookieName ),
+ versionOverride;
+
+ if ( M.query.wikigrokversion ) {
+ versionOverride = M.query.wikigrokversion.toUpperCase();
+
+ if ( versions.hasOwnProperty( versionOverride ) ) {
+ return versions[versionOverride];
+ }
+
+ return versions[DEFAULT_VERSION];
+ }
if ( !mw.user.isAnon() ) {
if ( M.isAlphaGroupMember() ) {
--
To view, visit https://gerrit.wikimedia.org/r/170324
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab2cf5640765d7dfefa06b48f1af2bc2d64b63d0
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
