jenkins-bot has submitted this change and it was merged.
Change subject: Remove extra dir=auto to fix directionallity problem
......................................................................
Remove extra dir=auto to fix directionallity problem
Currently due double nested dir="auto" RTL sitelinks are not right
aligned, this hack will let parent dir="auto" works at least
Change-Id: If5f21cee552fa3e322ec17ef0fb365d97573e32b
---
M lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
M lib/resources/templates.php
M repo/includes/View/SiteLinksView.php
3 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
index ef9b01c..57e5293 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js
@@ -174,8 +174,7 @@
siteLink ? site.getUrlTo(
siteLink.getPageName() ) : '',
siteLink ? siteLink.getPageName() : '',
mw.wbTemplate(
'wikibase-badgeselector', '' ),
- site ? site.getLanguageCode() : '',
- site ? site.getLanguageDirection() :
'auto'
+ site ? site.getLanguageCode() : ''
)
);
}
diff --git a/lib/resources/templates.php b/lib/resources/templates.php
index f041f79..6184f50 100644
--- a/lib/resources/templates.php
+++ b/lib/resources/templates.php
@@ -321,7 +321,7 @@
$templates['wikibase-sitelinkview-pagename'] =
<<<HTML
-$3<span class="wikibase-sitelinkview-page"><a href="$1" hreflang="$4"
dir="$5">$2</a></span>
+$3<span class="wikibase-sitelinkview-page"><a href="$1"
hreflang="$4">$2</a></span>
HTML;
$templates['wikibase-sitelinkview-unknown'] =
diff --git a/repo/includes/View/SiteLinksView.php
b/repo/includes/View/SiteLinksView.php
index e685239..0e9722a 100644
--- a/repo/includes/View/SiteLinksView.php
+++ b/repo/includes/View/SiteLinksView.php
@@ -334,8 +334,7 @@
htmlspecialchars( $site->getPageUrl( $pageName ) ),
htmlspecialchars( $pageName ),
$this->getHtmlForBadges( $siteLink ),
- $site->getLanguageCode(),
- 'auto'
+ $site->getLanguageCode()
);
}
--
To view, visit https://gerrit.wikimedia.org/r/167409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5f21cee552fa3e322ec17ef0fb365d97573e32b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ebrahim <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Ebrahim <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
