Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170586
Change subject: Return ArrayIterator in SqlUsageTracker::getPagesUsing
......................................................................
Return ArrayIterator in SqlUsageTracker::getPagesUsing
if empty, return an empty Array Iterator object and
not an array, since that is what is expected.
Change-Id: I08d3cb465181c9d47e935fafabe74d7fd0e69e86
---
M client/includes/Usage/Sql/SqlUsageTracker.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/86/170586/1
diff --git a/client/includes/Usage/Sql/SqlUsageTracker.php
b/client/includes/Usage/Sql/SqlUsageTracker.php
index 35eec2a..36dcb6a 100644
--- a/client/includes/Usage/Sql/SqlUsageTracker.php
+++ b/client/includes/Usage/Sql/SqlUsageTracker.php
@@ -226,7 +226,7 @@
*/
public function getPagesUsing( array $entityIds, array $aspects =
array() ) {
if ( empty( $entityIds ) ) {
- return array();
+ return new ArrayIterator();
}
$idStrings = $this->getEntityIdStrings( $entityIds );
--
To view, visit https://gerrit.wikimedia.org/r/170586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08d3cb465181c9d47e935fafabe74d7fd0e69e86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
